Fix/refactor code#230
Open
SrinandhiniM wants to merge 63 commits into
Open
Conversation
SrinandhiniM
commented
Feb 8, 2023
SrinandhiniM
commented
Collaborator
- Algorithm for Best post,Hot post and Top posts are updated now.
- Queries in Public Controller are minimized and now rendered the tabs using AJAX call.
* post select community automatically * code refactored * Helper method refactored
* issue/profile picture and cover photo validated (#124) * profile picture and cover photo validated * added concers for image validation * concern module name changed and refactored * update draft button is given in the edit drafts page and the functionality is done accordingly * Necessary refactoring done on post forms and controller logic is changed accordingly
* feature flash notification added * require packages added
* Profile page extra space is removed. * Database changed from MySQL to PostgreSQL * The pagination is added * Comments added * bugs solved * condition is changed using and in navbar file Co-authored-by: KSOWNDAR <sowndar.k.ece@sece.ac.in>
* Update README.md * updated Readme.md
Co-authored-by: KSOWNDAR <sowndar.k.ece@sece.ac.in>
* Create post button not visibile to non-community person * Name is changed to @subscribed Co-authored-by: KSOWNDAR <sowndar.k.ece@sece.ac.in>
* Editing page differences between post edit and draft edit page is done and cancel button is added for post edit page * Community is added as hidden field in edit page
* local flash notice added in seprate locale yml * flash yml locale file grouped * flash script moved to seprate partial file
* Profile page post view empty message * Query condition is changed in public controller Co-authored-by: KSOWNDAR <sowndar.k.ece@sece.ac.in>
* cancel moved to call back function * necessary conditions for edit and draft page given * necessary conditions for edit and draft page given * placeholder changed
* feature flash notification added * require packages added * mod UI * . * ISSUE at Banned Uers ,Only Joined Members Banned with Flash Notice * indentation resolved * Banned User Issue Ban anyone not in Community Resolved * resolve quote to : * comments reolved * refactored code * code refactored * username issue resolved * reolved code working * ode refactored * code aligned Co-authored-by: Vasanthakumar <vasanthakumara117@gmail.com> Co-authored-by: mithun30052001 <lmithun01@gmail.com>
* Query is moved to helper from view page * Logic moved to controller from helper Co-authored-by: KSOWNDAR <sowndar.k.ece@sece.ac.in>
* Empty message is added for saeve post page * Messages are moved to separate file to locale * Message name changed in notice Co-authored-by: KSOWNDAR <sowndar.k.ece@sece.ac.in>
…pdated at finished
* Js files loaded * Sensitive content done * js corrected * Post page tabs design corrected * Image size changed * Yarn files * Multiple images fixed * changes made * issue/post select community automatically (#134) * post select community automatically * code refactored * Helper method refactored * Fix/update draft (#135) * issue/profile picture and cover photo validated (#124) * profile picture and cover photo validated * added concers for image validation * concern module name changed and refactored * update draft button is given in the edit drafts page and the functionality is done accordingly * Necessary refactoring done on post forms and controller logic is changed accordingly * My communities in nav bar modified to display communities that user joined (#136) * Feat/toastr js (#137) * feature flash notification added * require packages added * Fix/sql to postgresql (#139) * Profile page extra space is removed. * Database changed from MySQL to PostgreSQL * The pagination is added * Comments added * bugs solved * condition is changed using and in navbar file Co-authored-by: KSOWNDAR <sowndar.k.ece@sece.ac.in> * Update README.md (#141) * Update README.md * updated Readme.md * bullet gem is added to solve N+1 queries (#150) Co-authored-by: KSOWNDAR <sowndar.k.ece@sece.ac.in> * Create post button not visibile to non-community person (#151) * Create post button not visibile to non-community person * Name is changed to @subscribed Co-authored-by: KSOWNDAR <sowndar.k.ece@sece.ac.in> * Update README.md (#154) * Fix/draft update pro (#156) * Editing page differences between post edit and draft edit page is done and cancel button is added for post edit page * Community is added as hidden field in edit page * feat/local flash notice added in seprate locale yml (#153) * local flash notice added in seprate locale yml * flash yml locale file grouped * flash script moved to seprate partial file * Profile page post view empty message (#157) * Profile page post view empty message * Query condition is changed in public controller Co-authored-by: KSOWNDAR <sowndar.k.ece@sece.ac.in> * Fix/cancel callback (#159) * cancel moved to call back function * necessary conditions for edit and draft page given * necessary conditions for edit and draft page given * placeholder changed * Issue/mod tools UI (#152) * feature flash notification added * require packages added * mod UI * . * ISSUE at Banned Uers ,Only Joined Members Banned with Flash Notice * indentation resolved * Banned User Issue Ban anyone not in Community Resolved * resolve quote to : * comments reolved * refactored code * code refactored * username issue resolved * reolved code working * ode refactored * code aligned Co-authored-by: Vasanthakumar <vasanthakumara117@gmail.com> Co-authored-by: mithun30052001 <lmithun01@gmail.com> * Query is moved to helper from view page (#155) * Query is moved to helper from view page * Logic moved to controller from helper Co-authored-by: KSOWNDAR <sowndar.k.ece@sece.ac.in> * Empty message is added for saved post page (#158) * Empty message is added for saeve post page * Messages are moved to separate file to locale * Message name changed in notice Co-authored-by: KSOWNDAR <sowndar.k.ece@sece.ac.in> * Sensitive content done * Feat/toastr js (#137) * feature flash notification added * require packages added * css added * Feat/toastr js (#137) * feature flash notification added * require packages added * Fix/cancel callback (#159) * cancel moved to call back function * necessary conditions for edit and draft page given * necessary conditions for edit and draft page given * placeholder changed * Update _navbar.html.erb * Sensitive content done * Feat/toastr js (#137) * feature flash notification added * require packages added * Fix/cancel callback (#159) * cancel moved to call back function * necessary conditions for edit and draft page given * necessary conditions for edit and draft page given * placeholder changed * Extra Space removed Co-authored-by: Srinandhini M <srinandhini@sedintechnologies.com> Co-authored-by: Vasanthakumar A <81355826+vasanthakumar-a@users.noreply.github.com> Co-authored-by: mithun30052001 <81811776+mithun30052001@users.noreply.github.com> Co-authored-by: Aboorva1 <113507326+Aboorva1@users.noreply.github.com> Co-authored-by: Sowndar K <84360457+ksowndar@users.noreply.github.com> Co-authored-by: KSOWNDAR <sowndar.k.ece@sece.ac.in> Co-authored-by: tushar R <57782379+tusharravindran@users.noreply.github.com> Co-authored-by: Vasanthakumar <vasanthakumara117@gmail.com> Co-authored-by: mithun30052001 <lmithun01@gmail.com> Co-authored-by: tushar R <tusharrravindran@gmail.com>
* Refactored community controller * designed communty form page and refatored * subscriptions controller refactored
Co-authored-by: KSOWNDAR <sowndar.k.ece@sece.ac.in>
* rubocop added to gem * All model files refactored using rubocop
Co-authored-by: KSOWNDAR <sowndar.k.ece@sece.ac.in>
* resolved save button before login * redirect to login on click save
Co-authored-by: KSOWNDAR <sowndar.k.ece@sece.ac.in>
* images * form changes * Post form tabs created * validates removed for title and body * Images in rich text now display in list page * Label added for images * file name changed * Indendation corrected * Helper method added * Corrections done
Co-authored-by: KSOWNDAR <sowndar.k.ece@sece.ac.in>
* post show page redesigned * Styles added for button in post show page * button styling code refactored Co-authored-by: KSOWNDAR <sowndar.k.ece@sece.ac.in>
* Issue#180 * hot post and top posts * Resolved Changes * Comment resolve Indentation * comments refactor resolved * indentation resolved
* Changes logic from controller to model * removed duplicates * Code refactored * refactored code in model as suggested
* Displayed profile image for community and account * Adjusted spacing * Renamed method as suggested
* params-name changed * redirect and flash message added in same line * Community column refactored (#205) * params name is changed in post controller
* removed owner_id from views and used account_id instead * removed owner_id from community db
* select2-autocomplete * commit * Fixed autocomple issue * adding package json for yarn - includes jquery, select2 * on change redirection done in autocomplete.js * navbar and create form page community selection is made as autocomplete * redirection to specific community is written as a seperate function so that it is used only in navbar and not inside form * Design issue in select community field in post form fixed * autocomplete dropdown brought into modal field but fetching data from username_search need to be done * Merge branch 'master' of https://github.com/MilesUpHQ/reddit-clone-rails into feat/autocomplete-select2 * Merge branch 'feat/autocomplete-select2' of https://github.com/MilesUpHQ/reddit-clone-rails into feat/autocomplete-select2 * some conflicts caused sue to creation of tabs are rectified * username data is loaded in banusers username fiels * The username selected is filled to the respective field correctly * unnecessary comments removed Co-authored-by: Magesh <pingmagesh@gmail.com>
* association added to post controller * modified routes and helper methods * added js redirect to community_post_path onChange * modified path
…ethod and creating a seperate form for the field (#214)
…ionality and no cache is added for select2 (#215)
* Changed name to post_params * Changed path for comments and reports * Removed hidden fields from comments form * Removed hidden fields from reports * Added separate method to set post * Removed set community * Changed name * Changed variable name which was given wrong * Added path for sign_out since it is not working * Sign out working properly after last pull. So removed the changes I made
* issue in content warning feature is fixed * button styles added
* Column for link is added and it is used in form * Link is visible now in post list page * link images is added * helper is added to check whether th post is link or not * partail file added for image displaying in Post. * File renamed for Partial File
* fixed banned user * poll form generated * Poll form list displayed now * Already polled answers conditon fixed * Design added * poll form generated * conflicts resolved * Issue/content warning (#219) * issue in content warning feature is fixed * button styles added * poll form generated * Poll form list displayed now * nsfw , sensitive added for poll feature Co-authored-by: Vasanthakumar <vasanthakumara117@gmail.com>
* feature flash notification added * require packages added
* Profile page extra space is removed. * Database changed from MySQL to PostgreSQL * The pagination is added * Comments added * bugs solved * condition is changed using and in navbar file Co-authored-by: KSOWNDAR <sowndar.k.ece@sece.ac.in>
* Issue#180 * hot post and top posts * Resolved Changes * Comment resolve Indentation * comments refactor resolved * indentation resolved
* Validation added for body,images,link and poll_topic in post form. * fixed banned user (#223) * Fix/link display (#221) * Column for link is added and it is used in form * Link is visible now in post list page * link images is added * helper is added to check whether th post is link or not * partail file added for image displaying in Post. * File renamed for Partial File * automation of yarn post install added (#225) * Feat/poll options new (#224) * fixed banned user * poll form generated * Poll form list displayed now * Already polled answers conditon fixed * Design added * poll form generated * conflicts resolved * Issue/content warning (#219) * issue in content warning feature is fixed * button styles added * poll form generated * Poll form list displayed now * nsfw , sensitive added for poll feature Co-authored-by: Vasanthakumar <vasanthakumara117@gmail.com> * Update post.rb Method name renamed --------- Co-authored-by: Vasanthakumar A <81355826+vasanthakumar-a@users.noreply.github.com> Co-authored-by: mithun30052001 <81811776+mithun30052001@users.noreply.github.com> Co-authored-by: Vasanthakumar <vasanthakumara117@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.