feat: add stellar contract bindings JSON generation step to CI - #48
Open
eulami wants to merge 1 commit into
Open
feat: add stellar contract bindings JSON generation step to CI#48eulami wants to merge 1 commit into
eulami wants to merge 1 commit into
Conversation
- Add `make bindings` target that runs:
stellar contract bindings json \
--wasm target/wasm32v1-none/release/milestonex_campaign.wasm \
--out bindings/
- Commit initial `bindings/milestonex_campaign.json` reflecting the
current campaign contract ABI (26 functions); CI will overwrite this
with the authoritative output on every WASM rebuild.
- Add `bindings-check` CI job that:
1. Builds the campaign WASM in release mode
2. Installs stellar-cli (--locked --features opt)
3. Regenerates bindings/milestonex_campaign.json
4. Fails with a clear message if the committed file is stale
Closes MillestoneX#37
P3az3
requested changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #37 — adds a
make bindingstarget and abindings-checkCI job so thatbindings/milestonex_campaign.jsonis always in sync with the compiled WASM.Changes
Makefilebindingsto.PHONYmake bindingstarget that depends onbuild-wasmand runs:make helpoutput.github/workflows/ci.ymlbindings-checkjob that:milestonex-campaignWASM in release modestellar-cli(--locked --features opt) — resolves the binary-name question from issue release_milestone` ignores actual on-contract balance for proportional math #14 by usingstellarnotsorobanbindings/milestonex_campaign.jsonbindings/milestonex_campaign.json(new file)milestonex-campaigncontractstellar contract bindings jsonon every buildTesting
make --dry-run helpCloses
Closes #37