Add Qdrant as vector database #580
Conversation
PaulKoudelka
requested review from
a team and
SommerEngineering
as code owners
SommerEngineering
left a comment
SommerEngineering
left a comment
There was a problem hiding this comment.
Thank you for the good work 😀. I only found a few minor things 👍
app/Build/Commands/Qdrant.cs
Outdated
| RID.LINUX_ARM64 => new("qdrant", "qdrant-aarch64-apple-darwin"), | ||
| RID.LINUX_X64 => new("qdrant", "qdrant-x86_64-apple-darwin"), | ||
|
|
||
| RID.OSX_ARM64 => new("qdrant", "qdrant-aarch64-unknown-linux-gnu"), | ||
| RID.OSX_X64 => new("qdrant", "qdrant-x86_64-unknown-linux-gnu"), |
There was a problem hiding this comment.
Linux and macOS filenames are swapped 😉
There was a problem hiding this comment.
We will then also need to update the German language
metadata.txt
Outdated
| osx-arm64 | ||
| 137.0.7215.0 | ||
| 137.0.7215.0 | ||
| v1.16.1 |
There was a problem hiding this comment.
We have specified all other versions without the v prefix. Can you change this so that the prefix is added after parsing?
| max_workers: 0 | ||
|
|
||
| # Host to bind the service on | ||
| host: 0.0.0.0 |
There was a problem hiding this comment.
Using 0.0.0.0 exposes the database on all network interfaces, increasing the attack surface. Please change it to 127.0.0.1 (aka localhost) 🙂
| enable_cors: true | ||
|
|
||
| # Enable HTTPS for the REST and gRPC API | ||
| enable_tls: false |
There was a problem hiding this comment.
Yes this part still needs to be integrated
|
|
||
| # Set to true to prevent service from sending usage statistics to the developers. | ||
| # Read more: https://qdrant.tech/documentation/guides/telemetry | ||
| telemetry_disabled: false |
There was a problem hiding this comment.
MindWork AI Studio currently does not send telemetry. Please disable it.
runtime/src/qdrant.rs
Outdated
| println!("{}", storage_path); | ||
| println!("{}", snapshot_path); | ||
| println!("{}", init_path); |
There was a problem hiding this comment.
Printing makes little sense in release. Should we log these values as info instead?
SommerEngineering
changed the title
|
@PaulKoudelka Please also update the |
2 participants
Added functionality to download Qdrant and execute it as a background sidecar.