Conversation
.erb files are commonly labeled 'embeddedtemplate' (no underscore) by downstream consumers, e.g. semble's file-extension table, but the bundled grammar is keyed as 'embedded_template' to match tree-sitter's canonical name. Without this alias, get_language/get_parser raised LanguageNotFoundError for a grammar that's actually bundled, silently degrading .erb handling to line-based fallback. Bumps version to 0.1.2.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The new alias is resolved through the shared loader path used by both public lookup APIs, its canonical target is bundled, and the version bump feeds directly into package metadata. Reviews (1): Last reviewed commit: "Add embeddedtemplate alias for embedded_..." | Re-trigger Greptile |
Member
Author
|
Combined into #7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.