Skip to content

Simplify batch/heex sources.json entries and parametrize alias tests - #8

Closed
Pringled wants to merge 1 commit into
mainfrom
simplify-batch-heex-aliases
Closed

Pringled wants to merge 1 commit into
mainfrom
simplify-batch-heex-aliases

Conversation

@Pringled

@Pringled Pringled commented Aug 1, 2026

Copy link
Copy Markdown
Member

Summary

  • Drop the explicit "sources": ["src/parser.c"] for batch/heex — that's GrammarSpec.sources's own default, and matches the convention already used by other single-parser.c entries (json, go, c, java, etc.).
  • Collapse the three near-identical alias tests (terraform/embeddedtemplate/zsh) into one parametrized test_aliases.

Test plan

  • make test (92 passed), make lint, make typecheck all pass

@greptile-apps

greptile-apps Bot commented Aug 1, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The omitted grammar source fields resolve to the same src/parser.c default, and the parametrized test preserves all three existing alias checks.

Reviews (1): Last reviewed commit: "Simplify batch/heex sources.json entries..." | Re-trigger Greptile

@Pringled Pringled closed this Aug 1, 2026
@Pringled
Pringled deleted the simplify-batch-heex-aliases branch August 1, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant