Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connects to #342. Connects to #344. Published paper screenshots. PreCAWG onboarding info update. #345

Merged
merged 9 commits into from
May 24, 2024

Conversation

jimmyzhen
Copy link
Contributor

Key Changes:

  • Changed the published PASS1B-06 landscape paper screenshot on homepage to respective Nature issue cover image, and its link to the online issue instead of the article itself.
  • Added screenshots to all published papers on the Publications page.
  • Highlighted the published landscape paper in its own section at top of the Publications page.
  • Moved the external links to top of the Publications page.
  • Added "Show all authors" and "Show less authors" UI to truncate long list of authors for the published landscape paper.
  • Updated PreCAWG onboarding information in the MAWG resources section.

@jimmyzhen jimmyzhen requested review from cteng585 and jyu-sm May 24, 2024 00:54
This was linked to issues May 24, 2024
@jyu-sm
Copy link
Collaborator

jyu-sm commented May 24, 2024

I verified all the publication changes but could not find: PreCAWG onboarding information (event after login). I think we need a site search in the future.

@jimmyzhen
Copy link
Contributor Author

@jyu-sm The multi-omics working group resources section can be accessed by clicking on the "Multi-omics Working Groups" card on the search page right after you signed in as a consortium member. This section is not available to external users.

Copy link
Collaborator

@cteng585 cteng585 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most things look good to me. The screenshots on the publications page are really nice.

My one piece of feedback is the low-resolution of the Nature cover on the front page. I'm not sure if it's possible to get a higher-res image but when I opened the page I immediately noticed it.

@jimmyzhen
Copy link
Contributor Author

@cteng585 Thanks for the comment. Unfortunately I was not able to find a higher resolution of the Nature issue cover image on the journal's website. We may need to reach out to the journal directly if we really want to pursue that.

@jimmyzhen jimmyzhen merged commit fd8b931 into dev May 24, 2024
6 checks passed
@jimmyzhen jimmyzhen deleted the 342_JZ_Publication_Screenshots branch May 30, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAWG section updates Add screenshots to publications page
3 participants