Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connects to #361. PASS1B-06 metabolomics DEA search result updates. #363

Merged
merged 16 commits into from
Jul 19, 2024

Conversation

jimmyzhen
Copy link
Contributor

Key Changes:

  • For PASS1B-06 metabolite DEA results search, the metabolite field used for retrieving data has now been changed to metabolite_refmet due to re-indexing metabolite DEA results using meta-regression datasets.
  • Added new UI on homepage for users to subscribe to future data updates.
  • Updated homepage UIs towards the end of the page due to the newly added subscription UI.
  • Updated homepage CSS to handle viewport responsiveness due to the newly added subscription UI.
  • Added styling to visually emphasize the first 2 PreCAWG onboarding bullet points.
  • Changed dependencies to improve page load time for pages with embedded YouTube videos.

@jimmyzhen jimmyzhen linked an issue Jul 18, 2024 that may be closed by this pull request
jyu-sm
jyu-sm previously approved these changes Jul 19, 2024
Copy link
Collaborator

@jyu-sm jyu-sm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked the metabolomics data search and the subscription link. They look good.

@cteng585 cteng585 self-requested a review July 19, 2024 18:15
cteng585
cteng585 previously approved these changes Jul 19, 2024
Copy link
Collaborator

@cteng585 cteng585 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me. My one piece of feedback is that the "module" prior to the office hours/signup "module" doesn't indicate that the user can scroll further down to see the office hours signups/data release subscription.

Also, I feel like the wording here can be workshopped:

Deep dive into our source codes integral to the MoTrPAC 6 month old rats performing endurance training exercise study, from ingestion to QC and from processing to analysis.

Specifically, "...into our source codes integral..." reads awkwardly to me.

@jimmyzhen
Copy link
Contributor Author

@cteng585 thank you for the comments. How would you change the wording for the code repo section?

@jimmyzhen jimmyzhen dismissed stale reviews from cteng585 and jyu-sm via 1659e79 July 19, 2024 21:21
@jimmyzhen jimmyzhen merged commit 29994d6 into dev Jul 19, 2024
6 checks passed
@jimmyzhen jimmyzhen deleted the 361_JZ_Metabolomics_DEA_Updates branch October 25, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the column header "metabolite" to "metabolite_refmet"
3 participants