Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor msgfplus wdl based on new version of plexedpiper #56

Merged
merged 15 commits into from
Jun 15, 2022

Conversation

biodavidjm
Copy link
Member

Summary of the main changes:

proteomics_msgfplus.wdl

The user must specify new options

VARIABLE NAME MODIFICATION

  • ptm_type is now called proteomics_experiment and is required for all proteomic experiments, i.e., not only for PTMs. The values currently accepted are: pr, ph, ub, ac.

Suggestion for OmicsPipeline: dropdown menu with these 4 options.

NEW REQUIRED VARIABLES

  • refine_prior: Peptides are allowed to match multiple proteins in the prior. However, if refine_prior = true, the greedy set cover algorithm is applied to the prior and non-prior sets separately before combining ids. Default: TRUE.
    This means that any redundancy would be removed. Suggestion for OmicsPipeline: add the default value by default in the form.
  • unique_only: Whether to discard peptides that match multiple proteins (not recommended). If TRUE, it will ignore arguments pr_ratio and refine_prior. Default: FALSE. Suggestion for OmicsPipeline: add the default value in the form (and let the user choose TRUE in a drop-down menu

Other changes: the wrapper_pp* tasks are now simplified to a one task wrapper_pp.

NEW SCRIPT: pp.R

This script is copied to the plexedpiper docker container.

Other updates

  • Scripts
  • Templates with new wdl input arguments
  • PlexedPiper docker file

@biodavidjm biodavidjm requested a review from mihirsamdarshi June 7, 2022 12:17
@biodavidjm biodavidjm merged commit 8bda00f into master Jun 15, 2022
@biodavidjm biodavidjm deleted the refactor/plexedpiper-unified branch March 9, 2023 18:25
mihirsamdarshi pushed a commit that referenced this pull request Apr 12, 2023
Refactor msgfplus wdl based on new version of plexedpiper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant