-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor msgfplus wdl based on new version of plexedpiper #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It copies the pp.R into the container
Update variables name
mihirsamdarshi
pushed a commit
that referenced
this pull request
Apr 12, 2023
Refactor msgfplus wdl based on new version of plexedpiper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the main changes:
proteomics_msgfplus.wdl
The user must specify new options
VARIABLE NAME MODIFICATION
ptm_type
is now calledproteomics_experiment
and is required for all proteomic experiments, i.e., not only for PTMs. The values currently accepted are:pr, ph, ub, ac
.Suggestion for OmicsPipeline: dropdown menu with these 4 options.
NEW REQUIRED VARIABLES
refine_prior
: Peptides are allowed to match multiple proteins in the prior. However, ifrefine_prior = true
, the greedy set cover algorithm is applied to the prior and non-prior sets separately before combining ids. Default:TRUE
.This means that any redundancy would be removed. Suggestion for OmicsPipeline: add the default value by default in the form.
unique_only
: Whether to discard peptides that match multiple proteins (not recommended). If TRUE, it will ignore argumentspr_ratio
andrefine_prior
. Default:FALSE
. Suggestion for OmicsPipeline: add the default value in the form (and let the user chooseTRUE
in a drop-down menuOther changes: the
wrapper_pp*
tasks are now simplified to a one taskwrapper_pp
.NEW SCRIPT:
pp.R
This script is copied to the plexedpiper docker container.
Other updates