Create xcodeproj_extra_files aspect hint #3150
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xcodeproj/defs.bzl
Outdated
| @@ -34,6 +35,7 @@ project_options = _project_options | |||
| top_level_target = _top_level_target | |||
| top_level_targets = _top_level_targets | |||
| xcodeproj = _xcodeproj | |||
| xcodeproj_extra_files = _xcodeproj_extra_files | |||
There was a problem hiding this comment.
We are moving away from a single file for loads, so let’s instead just have the aspect hint live one level up.
jflan-dd
commented
Mar 27, 2025
| @@ -36,6 +37,7 @@ genrule( | |||
| ":xcode_schemes", | |||
| ":xcode_build_settings", | |||
| ":providers", | |||
| ":aspect_hints", | |||
There was a problem hiding this comment.
This is giving me an error. I tried to mimic the setup for the other sets of documentation, but I think the issues is that this is the first one where the implementation is at the root of xcodeproj/ rather than in xcodeproj/internal/
ERROR: /Users/johnflanagan/Projects/src/rules_xcodeproj/docs/BUILD:19:12: in deps attribute of starlark_doc_extract rule //docs:aspect_hints.extract: missing bzl_library targets for Starlark module(s) //xcodeproj:xcodeproj_extra_files.bzl. Since this rule was created by the macro 'stardoc', the error might have been caused by the macro implementation
ERROR: /Users/johnflanagan/Projects/src/rules_xcodeproj/docs/BUILD:19:12: Analysis of target '//docs:aspect_hints.extract' failed
ERROR: Analysis of target '//docs:update' failed; build aborted: Analysis failed
jflan-dd
commented
Mar 27, 2025
|
|
||
| target_under_test = analysistest.target_under_test(env) | ||
|
|
||
| asserts.equals(env, depset(["BUILD"]), target_under_test[XcodeProjExtraFilesHintInfo].files) |
There was a problem hiding this comment.
This is failing with:
DEBUG: /Users/johnflanagan/Projects/src/rules_xcodeproj/bazel-output-base/external/bazel_skylib+/lib/unittest.bzl:465:10: In test _provider_contents_test_impl from //test/internal/xcodeproj_extra_files:xcodeproj_extra_files_tests.bzl: Expected "depset(["BUILD"])", but got "depset([<source file test/internal/xcodeproj_extra_files/BUILD>])"
jflan-dd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create an aspect hint to allow dependencies to propagate up extra files that should be include in the Xcode navigator