Skip to content

[fix]qwen3_vl add infer_state.max_seq_len #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WANDY666 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[fix]qwen3_vl add infer_state.max_seq_len #1164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lightllm/models/qwen2_vl/infer_struct.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ def init_some_extra_state(self, model):
self.position_ids = self.position_ids.contiguous()
self.position_cos = model._cos_cached[self.position_ids]
self.position_sin = model._sin_cached[self.position_ids]
if self.is_prefill:
self.max_seq_len = self.max_kv_seq_len
if get_env_start_args().enable_fa3:
self.max_seq_len = self.max_kv_seq_len
self.q_max_seq_len = self.max_q_seq_len
Comment on lines +38 to 42
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The logic for setting self.max_seq_len is redundant. It's set if self.is_prefill is true, and then potentially set again to the same value if get_env_start_args().enable_fa3 is true. This can be refactored to avoid the redundant assignment and make the logic clearer, while preserving the existing behavior.

Suggested change
if self.is_prefill:
self.max_seq_len = self.max_kv_seq_len
if get_env_start_args().enable_fa3:
self.max_seq_len = self.max_kv_seq_len
self.q_max_seq_len = self.max_q_seq_len
if self.is_prefill or get_env_start_args().enable_fa3:
self.max_seq_len = self.max_kv_seq_len
if get_env_start_args().enable_fa3:
self.q_max_seq_len = self.max_q_seq_len

Expand Down