[PORT] Dunking handle_atom_del() in the trash bin. #10973
Open
TheColorCyan wants to merge 3 commits intoMonkestation:masterfrom
Open
[PORT] Dunking handle_atom_del() in the trash bin. #10973TheColorCyan wants to merge 3 commits intoMonkestation:masterfrom
TheColorCyan wants to merge 3 commits intoMonkestation:masterfrom
Conversation
Whatever you do, if it warrants the use of something like `handle_atom_del`, chances are `Exited` can do it better, as most of these cases involve movables that shouldn't be moved out of their loc (`Destroy` forcefully moves movables to nullspace) without calling specific procs, and for the remaining few, `handle_atom_del` doesn't even cover the eventuality of a movable being deleted outside the source atom, so it's quite garbage. Beside, I feel confident in saying `handle_atom_del()` is older than the DCS, an echo on the workarounds done at the time.
github-project-automation
bot
moved this to In progress
in Monkestation-TG Issues Tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
ports tgstation/tgstation#77339
Why It's Good For The Game
Testing
tested with ballistics and couple more items works fine
Changelog
no player facing changes
Pre-Merge Checklist