Skip to content

Lighting updates / ports [MDB ignore]#5390

Draft
CheffieGithub wants to merge 11 commits intoMonkestation:mainfrom
CheffieGithub:lightig
Draft

Lighting updates / ports [MDB ignore]#5390
CheffieGithub wants to merge 11 commits intoMonkestation:mainfrom
CheffieGithub:lightig

Conversation

@CheffieGithub
Copy link
Collaborator

@CheffieGithub CheffieGithub commented Feb 24, 2026

About The Pull Request

Default area type is now one without dynamic lighting applied this to centcom and testing maps, this saves time mostly on roguetest due to the amount of these areas.

Fixes centcom dynamic lighting by adding it to our turf lists when its loaded.

Port multiple cleanup/optimsations of lighting
tgstation/tgstation#59002
tgstation/tgstation#67678
tgstation/tgstation#69838

Replaces outer_range with a falloff mult for range. The larger it is the less the range affects the lum calc.

This is because previously falloff was unused and most outer_range was set to the same as inner range (Without telling you it may modify it)

This speeds up lighting init by:
~10 seconds on roguetest (~70%!)
~20 seconds on vanderlin (~50%!)

Why It's Good For The Game

Changelog

🆑
refactor: Big lighting refactor, somethings may be too dim or too bright, report issues.
/:cl:

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

@github-actions github-actions bot added Code Maintenance Fixing this mess one line at a time Mapping You changed a map file, thank you for your tiles. May require additional approval. labels Feb 24, 2026
@CheffieGithub CheffieGithub changed the title Lighting updates / ports Lighting updates / ports [MDB ignore] Feb 24, 2026
@dwasint
Copy link

dwasint commented Feb 25, 2026

outer_range exists for a reason, the non outer range system is severely limiting in terms of low intensity lights because it forces fall off to be identical which we do not want.

@CheffieGithub
Copy link
Collaborator Author

I have added a falloff value that can achieve the same thing, but need to go through lights and some values due to the changed calc (mainly not squaring power)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Maintenance Fixing this mess one line at a time Mapping You changed a map file, thank you for your tiles. May require additional approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants