Add owner control quickstart to treasury runbook#424
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ```bash | ||
| npm run treasury:execute -- ./intents/transfer.json --envelopes ./envelopes \ | ||
| --treasury 0xa61a3b3a130a9c20768eebf97e21515a6046a1fa --rpc-url $RPC_URL --key $ORCHESTRATOR_KEY \ | ||
| --threshold 2 --registry config/guardians.json --ledger logs/intent-ledger.json |
There was a problem hiding this comment.
Pass chain id to execute step to match signatures
The new quickstart signs envelopes with --chain-id 1 just above, but the execute command omits --chain-id, so treasury:execute falls back to chainId 0 by default (scripts/treasury/execute-intent.ts options) and recomputes a different digest than the guardians signed. With mismatched digests aggregateGuardianEnvelopes rejects every envelope and the walkthrough cannot reach threshold even with valid approvals; the execution step needs the same chain id (or CHAIN_ID env) to succeed.
Useful? React with 👍 / 👎.
| npm run treasury:execute -- ./intents/transfer.json --envelopes ./envelopes \ | ||
| --treasury 0xa61a3b3a130a9c20768eebf97e21515a6046a1fa --rpc-url $RPC_URL --key $ORCHESTRATOR_KEY \ | ||
| --threshold 2 --registry config/guardians.json --ledger logs/intent-ledger.json |
There was a problem hiding this comment.
Use TreasuryExecutor address instead of AGIALPHA token
The execute command hardcodes --treasury 0xa61a3b3a130a9c20768eebf97e21515a6046a1fa, which is the $AGIALPHA ERC-20 token (src/constants/token.js), not the TreasuryExecutor contract that exposes executeTransaction/IntentExecuted. Pointing treasury:execute at the token address will always revert because that function doesn’t exist there, so the runbook fails unless operators substitute the deployed executor address.
Useful? React with 👍 / 👎.
Summary
Testing
npm run lintnpm run testnpm run test:frontendCodex Task