Skip to content

Add owner control quickstart to treasury runbook#424

Open
MontrealAI wants to merge 1 commit into
mainfrom
codex/implement-agi-alpha-node-sprint-tasks-eau8py
Open

Add owner control quickstart to treasury runbook#424
MontrealAI wants to merge 1 commit into
mainfrom
codex/implement-agi-alpha-node-sprint-tasks-eau8py

Conversation

@MontrealAI
Copy link
Copy Markdown
Owner

Summary

  • Expand the README with an owner control quickstart that walks through guardian key generation, signing, aggregation, and hot control levers
  • Keep treasury governance steps aligned with the deployed $AGIALPHA contract address and owner-only controls

Testing

  • npm run lint
  • npm run test
  • npm run test:frontend

Codex Task

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread README.md
Comment on lines +494 to +497
```bash
npm run treasury:execute -- ./intents/transfer.json --envelopes ./envelopes \
--treasury 0xa61a3b3a130a9c20768eebf97e21515a6046a1fa --rpc-url $RPC_URL --key $ORCHESTRATOR_KEY \
--threshold 2 --registry config/guardians.json --ledger logs/intent-ledger.json
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pass chain id to execute step to match signatures

The new quickstart signs envelopes with --chain-id 1 just above, but the execute command omits --chain-id, so treasury:execute falls back to chainId 0 by default (scripts/treasury/execute-intent.ts options) and recomputes a different digest than the guardians signed. With mismatched digests aggregateGuardianEnvelopes rejects every envelope and the walkthrough cannot reach threshold even with valid approvals; the execution step needs the same chain id (or CHAIN_ID env) to succeed.

Useful? React with 👍 / 👎.

Comment thread README.md
Comment on lines +495 to +497
npm run treasury:execute -- ./intents/transfer.json --envelopes ./envelopes \
--treasury 0xa61a3b3a130a9c20768eebf97e21515a6046a1fa --rpc-url $RPC_URL --key $ORCHESTRATOR_KEY \
--threshold 2 --registry config/guardians.json --ledger logs/intent-ledger.json
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use TreasuryExecutor address instead of AGIALPHA token

The execute command hardcodes --treasury 0xa61a3b3a130a9c20768eebf97e21515a6046a1fa, which is the $AGIALPHA ERC-20 token (src/constants/token.js), not the TreasuryExecutor contract that exposes executeTransaction/IntentExecuted. Pointing treasury:execute at the token address will always revert because that function doesn’t exist there, so the runbook fails unless operators substitute the deployed executor address.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant