Skip to content

Harden container entrypoint for one-click deployments#60

Open
MontrealAI wants to merge 1 commit into
mainfrom
codex/develop-docker-image-for-alpha-node-deployment-dtb9u5
Open

Harden container entrypoint for one-click deployments#60
MontrealAI wants to merge 1 commit into
mainfrom
codex/develop-docker-image-for-alpha-node-deployment-dtb9u5

Conversation

@MontrealAI
Copy link
Copy Markdown
Owner

Summary

  • expand the Docker entrypoint so config files are loaded, identity inputs validated, and runtime toggles mapped into the container command while still supporting other CLI operations
  • add documentation for one-click docker usage, ship a sample node.env template, and expose service ports from the container image
  • surface monitor cadence controls through Helm values and propagate the new environment variables into the deployment manifest

Testing

  • npm test

Codex Task

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +31 to +44
load_config_file() {
if [ "${CONFIG_PATH:-}" = "" ]; then
return
fi

if [ ! -f "$CONFIG_PATH" ]; then
echo "[entrypoint] CONFIG_PATH set to '$CONFIG_PATH' but file not found" >&2
log "CONFIG_PATH set to '$CONFIG_PATH' but file not found"
exit 1
fi
echo "[entrypoint] loading configuration from $CONFIG_PATH"
set -a

log "loading configuration from $CONFIG_PATH"
# shellcheck disable=SC1090
. "$CONFIG_PATH"
set +a
fi
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore export of variables loaded via CONFIG_PATH

The new load_config_file function sources the file but no longer wraps it in set -a/set +a. Variables defined in a node.env file are therefore not exported to the child node process when the file is loaded via CONFIG_PATH. This regresses the documented one-click docker run flow where the env file holds values like RPC_URL, NODE_LABEL, contract addresses, etc.—they are visible to the shell for validation but disappear from process.env, causing the runtime to fall back to defaults or fail schema validation. The previous version exported these values, so configuration files now silently stop working. Reintroduce automatic exporting (or explicitly export required variables) before invoking the Node CLI.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant