Keep mission control surface enabled in demos#3822
Open
MontrealAI wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
plan/verify/dashboardchecks.Description
--skip-surfaceinscripts/v2/asiGlobalDemo.tsandscripts/v2/asiTakeoffDemo.tswhile retaining--skip-plan,--skip-verify, and--skip-dashboardso the surface step runs.resolveBlockGasLimit()and used the computedgasLimitfortoken.mintand Deployer entrypoints inscripts/v2/deployDefaults.tsto cap gas to the latest block limit.hasDeployedCode()and guardedRewardEngineMB/Thermostatinstantiation inscripts/v2/thermodynamicsReport.ts, plus new placeholder configsconfig/job-registry.hardhat.jsonandconfig/thermodynamics.hardhat.jsonand normalization ofsettlersinconfig/thermodynamics.ci.json.v1.4.4, and added aSet registry ownerstep inrelease.yml.Testing
npm run demo:asi-takeoffprior to the fix which completed compilation, owner dry-run, and thermodynamics but failed at the mission-control step with "At least one step must be enabled" (failed).npm run demo:asi-takeoffagain and it failed early due tots-nodenot being available in the environment (failed).Codex Task