Skip to content

Keep mission control surface enabled in demos#3822

Open
MontrealAI wants to merge 2 commits into
mainfrom
codex/fix-github-actions-workflow-files-nsuqho
Open

Keep mission control surface enabled in demos#3822
MontrealAI wants to merge 2 commits into
mainfrom
codex/fix-github-actions-workflow-files-nsuqho

Conversation

@MontrealAI
Copy link
Copy Markdown
Owner

Motivation

  • Prevent demos from failing with "At least one step must be enabled" while still skipping heavy plan/verify/dashboard checks.
  • Avoid transaction failures caused by specifying gas above the current block limit by capping gas on local deploy/mint calls.
  • Prevent thermodynamics reporting from throwing when referenced contracts are not deployed by checking for on-chain bytecode first.
  • Make CI/demo workflows and local configs more robust for deterministic/local runs.

Description

  • Re-enabled the mission-control surface by removing --skip-surface in scripts/v2/asiGlobalDemo.ts and scripts/v2/asiTakeoffDemo.ts while retaining --skip-plan, --skip-verify, and --skip-dashboard so the surface step runs.
  • Added resolveBlockGasLimit() and used the computed gasLimit for token.mint and Deployer entrypoints in scripts/v2/deployDefaults.ts to cap gas to the latest block limit.
  • Added hasDeployedCode() and guarded RewardEngineMB/Thermostat instantiation in scripts/v2/thermodynamicsReport.ts, plus new placeholder configs config/job-registry.hardhat.json and config/thermodynamics.hardhat.json and normalization of settlers in config/thermodynamics.ci.json.
  • Updated GitHub workflows to quote hex env keys, bumped Foundry toolchain to v1.4.4, and added a Set registry owner step in release.yml.

Testing

  • Ran npm run demo:asi-takeoff prior to the fix which completed compilation, owner dry-run, and thermodynamics but failed at the mission-control step with "At least one step must be enabled" (failed).
  • After enabling the mission-control surface, attempted npm run demo:asi-takeoff again and it failed early due to ts-node not being available in the environment (failed).

Codex Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant