Skip to content

Allow mission control surface errors in demos#3823

Open
MontrealAI wants to merge 1 commit into
mainfrom
codex/fix-github-actions-workflow-files-cfvdu7
Open

Allow mission control surface errors in demos#3823
MontrealAI wants to merge 1 commit into
mainfrom
codex/fix-github-actions-workflow-files-cfvdu7

Conversation

@MontrealAI
Copy link
Copy Markdown
Owner

Motivation

  • Prevent demos from failing when the owner control surface reports many placeholder or missing modules as errors.
  • Allow lightweight demo runs to include the mission-control output while skipping heavy checks like plan/verify/dashboard.
  • Provide an explicit, opt-in way to suppress non-zero exits from the surface for local/deterministic demos.

Description

  • Add an allowErrors?: boolean option to ownerControlSurface and support a new --allow-errors CLI flag and OWNER_CONTROL_SURFACE_ALLOW_ERRORS env var read in scripts/v2/ownerControlSurface.ts.
  • Document the new option in the CLI help and conditionally suppress setting a non-zero process.exitCode when allowErrors is true.
  • Set OWNER_CONTROL_SURFACE_ALLOW_ERRORS='true' in the mission-control steps of scripts/v2/asiGlobalDemo.ts and scripts/v2/asiTakeoffDemo.ts so demos can include the surface without failing.

Testing

  • Ran npm run demo:asi-takeoff; the run started (constants generated and compilation began) but was manually interrupted during the long compile, so the end-to-end demo run is incomplete (interrupted).
  • No automated test suite was fully executed to completion for the new flag during this rollout.

Codex Task

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4b8244cad9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +403 to +405
env: {
OWNER_CONTROL_SURFACE_ALLOW_ERRORS: 'true',
},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Ignore surface error status in mission control

Setting OWNER_CONTROL_SURFACE_ALLOW_ERRORS here only suppresses the non‑zero exit of ownerControlSurface, but ownerMissionControl still marks the surface step as error when any module reports error (see scripts/v2/ownerMissionControl.ts lines 744‑771) and then exits 1 when overall status is error (lines 1225‑1227). That means demos where the surface reports placeholder/missing modules as errors will still fail despite this env flag; the same applies to asiTakeoffDemo. Consider adding a mission‑control flag to downgrade surface errors to warnings (or keep --skip-surface) if the goal is non‑failing demos.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant