Allow mission control surface errors in demos#3823
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b8244cad9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| env: { | ||
| OWNER_CONTROL_SURFACE_ALLOW_ERRORS: 'true', | ||
| }, |
There was a problem hiding this comment.
Ignore surface error status in mission control
Setting OWNER_CONTROL_SURFACE_ALLOW_ERRORS here only suppresses the non‑zero exit of ownerControlSurface, but ownerMissionControl still marks the surface step as error when any module reports error (see scripts/v2/ownerMissionControl.ts lines 744‑771) and then exits 1 when overall status is error (lines 1225‑1227). That means demos where the surface reports placeholder/missing modules as errors will still fail despite this env flag; the same applies to asiTakeoffDemo. Consider adding a mission‑control flag to downgrade surface errors to warnings (or keep --skip-surface) if the goal is non‑failing demos.
Useful? React with 👍 / 👎.
Motivation
Description
allowErrors?: booleanoption toownerControlSurfaceand support a new--allow-errorsCLI flag andOWNER_CONTROL_SURFACE_ALLOW_ERRORSenv var read inscripts/v2/ownerControlSurface.ts.process.exitCodewhenallowErrorsis true.OWNER_CONTROL_SURFACE_ALLOW_ERRORS='true'in themission-controlsteps ofscripts/v2/asiGlobalDemo.tsandscripts/v2/asiTakeoffDemo.tsso demos can include the surface without failing.Testing
npm run demo:asi-takeoff; the run started (constants generated and compilation began) but was manually interrupted during the long compile, so the end-to-end demo run is incomplete (interrupted).Codex Task