Ensure mission-control runs a step in demos; cap gas & guard thermodynamics#3824
Open
MontrealAI wants to merge 1 commit into
Open
Ensure mission-control runs a step in demos; cap gas & guard thermodynamics#3824MontrealAI wants to merge 1 commit into
MontrealAI wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ownerMissionControlis invoked with all checks skipped by ensuring at least one step runs.intrinsic gas too highdeploy/mint failures by keeping transaction gas under the latest block limit.Description
--only 'surface'toownerMissionControlinvocations inscripts/v2/asiGlobalDemo.tsandscripts/v2/asiTakeoffDemo.ts.resolveBlockGasLimit()toscripts/v2/deployDefaults.tsand use the computedgasLimitfortoken.mint,Deployer.deploy*calls, and deploy transactions.hasDeployedCode()and conditional contract instantiation inscripts/v2/thermodynamicsReport.tsto skip missing contracts and emit notes.config/job-registry.hardhat.jsonandconfig/thermodynamics.hardhat.json, normalizesettlersinconfig/thermodynamics.ci.json, quote hex env keys and bump Foundry tov1.4.4in multiple GitHub workflow files, and setREGISTRY_OWNERinrelease.yml.Testing
253Solidity files successfully (success).pass.npm run demo:asi-takeoffwhich began execution but was manually interrupted (interrupted).Codex Task