Skip to content

Ensure mission-control runs a step in demos; cap gas & guard thermodynamics#3824

Open
MontrealAI wants to merge 1 commit into
mainfrom
codex/fix-github-actions-workflow-files-izlqhw
Open

Ensure mission-control runs a step in demos; cap gas & guard thermodynamics#3824
MontrealAI wants to merge 1 commit into
mainfrom
codex/fix-github-actions-workflow-files-izlqhw

Conversation

@MontrealAI
Copy link
Copy Markdown
Owner

Motivation

  • Avoid demo failures when ownerMissionControl is invoked with all checks skipped by ensuring at least one step runs.
  • Prevent intrinsic gas too high deploy/mint failures by keeping transaction gas under the latest block limit.
  • Prevent thermodynamics reporting from throwing when target contracts are not deployed by skipping on-chain instantiation for absent bytecode.
  • Harden CI/demo workflows and provide missing hardhat configs so local rehearsals run more reliably.

Description

  • Ensure mission control executes a step by adding --only 'surface' to ownerMissionControl invocations in scripts/v2/asiGlobalDemo.ts and scripts/v2/asiTakeoffDemo.ts.
  • Add resolveBlockGasLimit() to scripts/v2/deployDefaults.ts and use the computed gasLimit for token.mint, Deployer.deploy* calls, and deploy transactions.
  • Add hasDeployedCode() and conditional contract instantiation in scripts/v2/thermodynamicsReport.ts to skip missing contracts and emit notes.
  • Add config/job-registry.hardhat.json and config/thermodynamics.hardhat.json, normalize settlers in config/thermodynamics.ci.json, quote hex env keys and bump Foundry to v1.4.4 in multiple GitHub workflow files, and set REGISTRY_OWNER in release.yml.

Testing

  • Ran Hardhat compile as part of the demo which compiled 253 Solidity files successfully (success).
  • Executed the owner testnet dry-run which completed with status pass.
  • Produced the thermodynamics report as JSON which completed and emitted notes for missing contracts (success).
  • Started npm run demo:asi-takeoff which began execution but was manually interrupted (interrupted).

Codex Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant