Quote long 0x hex literals in GitHub workflow files to fix YAML parsing#3826
Open
MontrealAI wants to merge 1 commit into
Open
Quote long 0x hex literals in GitHub workflow files to fix YAML parsing#3826MontrealAI wants to merge 1 commit into
MontrealAI wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
0x...literals being parsed as YAML hex integers (overflow/invalid integer) and causing “Invalid workflow file” errors.envblocks (private keys / validator keys) and must be treated as strings.Description
0x...literals wherever they appeared in.github/workflows/*so YAML treats them as strings (e.g. changed0xabc...→"0xabc...")..github/workflows/ci.yml,.github/workflows/demo-asi-global.yml,.github/workflows/demo-asi-takeoff.yml,.github/workflows/demo-aurora.yml,.github/workflows/demo-zenith-hypernova.yml,.github/workflows/demo-zenith-sapience-celestial-archon.yml,.github/workflows/demo-zenith-sapience-initiative.yml,.github/workflows/demo-zenith-sapience-omnidominion.yml, and.github/workflows/demo-zenith-sapience-planetary-os.yml.CHAIN_IDand other numeric-looking values were left intact where already appropriate.pyyamlparse check to prevent regressions.Testing
yaml.safe_loadover.github/workflows/*.ymland the script reportedYAML parse OK(success).npm run ci:sync-contexts -- --checkand it confirmed the required contexts are in sync (success).npm run ci:verify-contextsandnpm run ci:verify-companion-contextsand both reported successful verification of workflow display names and companion contexts (success).npm run ci:verify-summary-needsand it confirmed the summaryneedslist covers all non-summary jobs (success).Codex Task