fix(ci): quote long 0x hex in workflows and add preflight guard#3828
Open
MontrealAI wants to merge 1 commit into
Open
fix(ci): quote long 0x hex in workflows and add preflight guard#3828MontrealAI wants to merge 1 commit into
MontrealAI wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
0x…scalars were being treated as YAML integers (tag:yaml.org,2002:int) instead of strings.env:blocks which must be quoted to avoid parser errors.Description
.github/workflows/(e.g.ci.yml,demo-asi-global.yml,demo-aurora.yml,demo-zenith-*), changing values likeAURORA_WORKER_KEY: 0x…toAURORA_WORKER_KEY: '0x…'.scripts/ci/check-workflow-hex.jswhich scans.github/workflows/**/*.ymland fails if it finds unquoted: 0x[0-9a-fA-F]{16,}occurrences.ci:preflightscript inpackage.jsonto runnode scripts/ci/check-workflow-hex.js..gitignoreso it can be committed, and kept all changes minimal (only quoting and minor whitespace as needed).Testing
npm installwhich completed successfully.npm run ci:preflightand the toolchain, lock integrity, and the new workflow hex guard all passed (✅ Toolchain lock verification passed.,✅ All package-lock.json files are valid.,Workflow YAML hex values are properly quoted.).npm run ci:verify-toolchainandnpm run ci:sync-contexts -- --checkwhich both succeeded.npm run ci:verify-contexts,npm run ci:verify-companion-contexts, andnpm run ci:verify-summary-needsand all checks reported success.Codex Task