Skip to content

Fix apps-images build contexts; finalize workflow and demo fixes#3850

Open
MontrealAI wants to merge 1 commit into
mainfrom
codex/make-all-github-actions-checks-green-s6xei8
Open

Fix apps-images build contexts; finalize workflow and demo fixes#3850
MontrealAI wants to merge 1 commit into
mainfrom
codex/make-all-github-actions-checks-green-s6xei8

Conversation

@MontrealAI

Copy link
Copy Markdown
Owner

Motivation

  • Ensure Docker builds for the console and portal can find their app-local files by running buildx from the correct build contexts.
  • Avoid invalid GHCR image tags and provenance subjects by normalizing the registry owner and making it available to workflows.
  • Make local demo deployments robust against provider gas limits and improve network inference for demo bootstrapping.
  • Validate that demo bootstrap produces non-zero addresses by adding a test for the hardhat demo flow.

Description

  • Set docker/build-push-action context to apps/console and apps/enterprise-portal in .github/workflows/apps-images.yml so nginx.conf and other local files are present during build.
  • Compute and export a lower-cased REGISTRY_OWNER and replace uses of toLower(github.repository_owner) with env.REGISTRY_OWNER across workflows, and expose registry_owner job outputs for SLSA provenance subjects.
  • Add an actionlint workflow (.github/workflows/actionlint.yml) and apply multiple workflow fixes including quoting hex env vars and GITHUB_WORKSPACE script invocations, bumping foundry-toolchain to v1.4.4, and other YAML/shell cleanup.
  • Add local gas handling in scripts/v2/deployDefaults.ts via getLocalGasLimitOverride() and apply gasLimit overrides to mint, Deployer deployment, and deploy* calls, improve network inference in scripts/v2/ownerParameterMatrix.ts by using inferNetworkKey and CHAIN_ID, and add the test test/v2/DemoOwnerMatrixBootstrap.test.js to assert non-zero demo addresses after bootstrap.

Testing

  • Reproduced the Docker build failure where docker/build-push-action could not find /nginx.conf when building from the repo root and fixed it by setting the per-app context to apps/console and apps/enterprise-portal which makes the file available to the build.
  • No automated CI/unit/integration test suites were executed as part of this rollout.
  • Added actionlint workflow to catch future workflow issues but it was not executed in this rollout.
  • Added test/v2/DemoOwnerMatrixBootstrap.test.js to verify demo bootstrap addresses but the test was not run in CI during this change.

Codex Task

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 017f11e411

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +136 to 137
context: apps/enterprise-portal
file: apps/enterprise-portal/Dockerfile

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep portal build context compatible with Dockerfile

Setting the portal image context to apps/enterprise-portal will break the Docker build because apps/enterprise-portal/Dockerfile still uses COPY apps/enterprise-portal/... (e.g., lines 3, 11, 19), which requires the repo root as the build context. With the narrower context, those paths resolve to apps/enterprise-portal/apps/enterprise-portal/... and the build will fail in the Build Portal image step. Either keep the context at the repo root or update the Dockerfile to use paths relative to apps/enterprise-portal.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant