Fix apps-images build contexts; finalize workflow and demo fixes#3850
Fix apps-images build contexts; finalize workflow and demo fixes#3850MontrealAI wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 017f11e411
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| context: apps/enterprise-portal | ||
| file: apps/enterprise-portal/Dockerfile |
There was a problem hiding this comment.
Keep portal build context compatible with Dockerfile
Setting the portal image context to apps/enterprise-portal will break the Docker build because apps/enterprise-portal/Dockerfile still uses COPY apps/enterprise-portal/... (e.g., lines 3, 11, 19), which requires the repo root as the build context. With the narrower context, those paths resolve to apps/enterprise-portal/apps/enterprise-portal/... and the build will fail in the Build Portal image step. Either keep the context at the repo root or update the Dockerfile to use paths relative to apps/enterprise-portal.
Useful? React with 👍 / 👎.
Motivation
Description
contexttoapps/consoleandapps/enterprise-portalin.github/workflows/apps-images.ymlsonginx.confand other local files are present during build.REGISTRY_OWNERand replace uses oftoLower(github.repository_owner)withenv.REGISTRY_OWNERacross workflows, and exposeregistry_ownerjob outputs for SLSA provenance subjects.actionlintworkflow (.github/workflows/actionlint.yml) and apply multiple workflow fixes including quoting hex env vars andGITHUB_WORKSPACEscript invocations, bumping foundry-toolchain tov1.4.4, and other YAML/shell cleanup.scripts/v2/deployDefaults.tsviagetLocalGasLimitOverride()and applygasLimitoverrides tomint,Deployerdeployment, anddeploy*calls, improve network inference inscripts/v2/ownerParameterMatrix.tsby usinginferNetworkKeyandCHAIN_ID, and add the testtest/v2/DemoOwnerMatrixBootstrap.test.jsto assert non-zero demo addresses after bootstrap.Testing
docker/build-push-actioncould not find/nginx.confwhen building from the repo root and fixed it by setting the per-appcontexttoapps/consoleandapps/enterprise-portalwhich makes the file available to the build.actionlintworkflow to catch future workflow issues but it was not executed in this rollout.test/v2/DemoOwnerMatrixBootstrap.test.jsto verify demo bootstrap addresses but the test was not run in CI during this change.Codex Task