Fix console Docker build context and GHCR owner handling; add actionlint and local demo fixes#3851
Fix console Docker build context and GHCR owner handling; add actionlint and local demo fixes#3851MontrealAI wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4b47e4d52
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| permissions: | ||
| contents: read | ||
| pull-requests: read |
There was a problem hiding this comment.
Restore administration:read for branch protection audit
The branch_protection job still runs npm run ci:verify-branch-protection on non‑fork runs, and that script calls the GitHub branch protection API; the repo’s own docs state this check requires a token with administration:read scope (see ci/README.md “Branch protection automation”). With the permission removed here, the GITHUB_TOKEN will lack that scope on pushes/internal PRs, so the API request will 403 and the guard job will fail instead of auditing branch protection.
Useful? React with 👍 / 👎.
Motivation
apps/console/Dockerfileexpectednginx.confat the repo root by using the correct build context.docker/build-push-action.actionlint.Description
.github/workflows/apps-images.ymland.github/workflows/release.ymlto build the console image withcontext: apps/consoleandfile: Dockerfile, and add aREGISTRY_OWNER(lower-cased) environment value and outputs used in tags and provenance..github/workflows/actionlint.ymlto runrhysd/actionlint@v1.7.10and quote hex env vars and script invocations across CI/demo workflows to fix shell/parsing issues.scripts/v2/deployDefaults.ts(LOCAL_NETWORKS,getLocalGasLimitOverride) and threadtxOverridesinto contract deploy calls, improve network inference inscripts/v2/ownerParameterMatrix.tsusinginferNetworkKey/CHAIN_ID, and addtest/v2/DemoOwnerMatrixBootstrap.test.jsto assert non-zero demo addresses after bootstrap.Testing
docker buildx build.actionlintworkflow was added to the repository but was not executed as part of this rollout.test/v2/DemoOwnerMatrixBootstrap.test.jswas added but was not run in this environment.Codex Task