Decouple TS ICS validator from Python tests, gate torch demos, and reduce Foundry/CI noise#3860
Open
MontrealAI wants to merge 2 commits into
Open
Decouple TS ICS validator from Python tests, gate torch demos, and reduce Foundry/CI noise#3860MontrealAI wants to merge 2 commits into
MontrealAI wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
torchdependency.actions/download-artifactSHA that interfered artifact downloads.Description
test/orchestrator/test_ics_golden.pyso the fixture equality test always runs and the TS validator is skipped unlessnode+ts-nodeare available, invoking the validator viats-node/esmwith explicitTS_NODE_COMPILER_OPTIONSwhen present.pytest.importorskip('torch')and mark tests with@pytest.mark.requires_torch, add therequires_torchmarker topytest.ini, and update the demo workflow to exclude those tests by default withpytest -m "not requires_torch"..github/workflows/ci.yml(remove-vvvstyle flags and lower--fuzz-runs), updateactions/download-artifactusages to@v4in CI/release/culture workflows, and runprettierto fix HGM demo formatting.BRANCH_PROTECTION_ENFORCE=1with an elevated token that hasadministration:read.Testing
npm ciandnpm run lint:cisuccessfully to validate Node toolchain and lint rules.python -m pip install -r requirements-python.txtand ran the CI-equivalent pytest suites excluding heavy torch tests (-m "not requires_torch"), resulting in all Python unit and integration suites passing.npm run ci:verify-branch-protection -- --branch main --owner MontrealAI --repo AGIJobsv0which emits the configured NOTICE when no elevated token is present and succeeds; setBRANCH_PROTECTION_ENFORCE=1plus a token withadministration:readto enforce failure-on-misconfiguration.ci/hgm-suite.shand HGM demos formatting checks successfully, and reduced Foundry fuzz/verbosity to make CI runs more stable (note: a full Foundry run was started locally and is large; CI budgets were lowered to avoid excessive compile/fuzz time).How to run optional torch tests: install
torch(e.g., follow the demo workflow orpip installwith the appropriate wheel) and runpytest -m requires_torchor use the scheduledtorch-testsworkflow which installs CPU wheels and runs the marker suite.Codex Task