Fix: Ensure new database files are saved with .json extension#4
Open
Creepybits wants to merge 5 commits intoMoonMoon82:mainfrom
Open
Fix: Ensure new database files are saved with .json extension#4Creepybits wants to merge 5 commits intoMoonMoon82:mainfrom
Creepybits wants to merge 5 commits intoMoonMoon82:mainfrom
Conversation
Added logic for automatically set .json extension to new databases
Added logic to automatically set .json extention to new databases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When creating a new database, if the user does not manually add the .json extension to the filename, the file is saved without an extension. This makes it unusable by the loader node without manual renaming.
Solution: Added a check to the start_gen_db function that automatically appends the .json extension to the new_db_name if it is missing. This makes the node more robust and user-friendly.