fix(errors): surface real bundle failure identity to the user (#1)#28
Merged
Conversation
The provider client reads the structured failureDetail/error body and throws a BundleFailedError carrying the real code+message; the flow handlers thread that code through, and a new code->copy mapper renders mapped user copy on the confirmation pages instead of a generic string (#1).
AquiGorka
force-pushed
the
fix/error-bubbling
branch
from
95ddf86 to
9a3b8b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mid-flight error-bubbling fix (ClickUp 86c8t0zux, half 2). Part of the coordinated landing anchored by moonlight-sdk#39 / provider-platform#131.
Hole fixed
failureDetail/error body and throws aBundleFailedErrorcarrying the realcode+message; flow handlers thread that code through; a newcode → copymapper (popup/utils/error-copy.ts) renders mapped user copy on the deposit/send/withdraw confirmation pages instead of a generic string.Verify
deno checkclean,deno lintclean,deno task build-prodsucceeds. Rendered in-browser viatest.sh invite-gate(moonlight-pay/consoles load). No unit-test suite in this repo.SDK: no new symbol used — SDK pin unchanged (CI green independent of the SDK publish).
Note: the
src/popup/style.cssformatting drift is unrelated to this PR and is addressed separately by #27.