fix(recording): restore Playwright spec 03 to green against current stack#109
Merged
Conversation
Two changes inside the recording rig — no new behaviour beyond restoring the previously-green path: 1. spec 03 now discovers the PP's stellar public key via council-platform's public listing (`/api/v1/public/providers? councilId=…`, label match) instead of passing `env.PP_PK` (the PP operator's pubkey, not the PP itself). The per-PP URL paths added by provider-platform#106 need the PP's own key. 2. `addAndConnectProvider` now (a) fills the new `Provider Public Key` input added in browser-wallet#20, (b) re-opens the channel picker sheet after Approve, completes the KYC form if the wallet surfaces the "Submit KYC" prompt (entityStatus != APPROVED), and (c) closes the sheet with Escape so the home view's Receive/Send/Ramp aren't blocked by the overlay. Specs 01, 02, 04 were verified untouched-green against the same patched stack. Spec 03 reached green end-to-end in 5.4 min including Bob's withdraw and the public-balance closing beat. Requires browser-wallet#20 and provider-platform#109 deployed first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores recording-rig spec 03 (Bob + Alice private transfer) end-to-end after the stack-wide moves landed since 2026-05-22. Specs 01, 02, 04 were already green on this branch's stack and are untouched. Just the rig changes — no application code in local-dev.
Depends on
browser-wallet#20andprovider-platform#109being deployed first.What broke + how this fixes it
Pulled from the pairing thread's diagnose:
Failed to fetch Quorum Contract ID(SIM_002) — wallet's service-workerfetchtohttp://localhost:8000/soroban/rpcblocked by extension_pages CSP added in browser-wallet#18/api/v1/bundle— provider-platform#106 moved bundle endpoints under/api/v1/providers/:ppPublicKey/entity/bundlesSubmitter not approved(BND_011) — wallet had no surface for KYC submissionenv.PP_PKis the operator pubkey, not the PP's own pubkey that goes in the URL pathSpec / fixture changes
specs/03-private-transfer.spec.ts: discover the PP's pubkey from council-platform's/api/v1/public/providers?councilId=…(label match ongetProviderName()), and feed it + a per-wallet KYC entity name intoaddAndConnectProvider.fixtures/browser-wallet.ts(addAndConnectProvider):#provider-pubkeyinput added in browser-wallet#20.No other beats changed. The original
showReceive/deposit/send/withdraw/toggleToPublicViewflow is untouched.Verification
Local stack: 3 councils × 12 PPs (post-#101 setup) + spec-02's Provider Helios, on
provider-platform@feat/sep10-verify-returns-entity-status(0.7.0) +browser-wallet@feat/per-pp-urls-and-kyc-step.01-council-onboard: PASS (2.4 min)02-provider-create-join-approve: PASS (3.2 min)03-private-transfer: PASS (5.4 min) — full Bob→Alice flow, withdraw, closing public-balance beat04-dashboard-tour: PASS (24 s)Out of scope (follow-up)
Test plan
RUN_ID=… npm run recordend-to-end after browser-wallet#20 + provider-platform#109 merge