ci: run multi-asset E2E wherever the e2e gate runs (cross-repo trigger)#118
Merged
Conversation
multi-asset.yml triggered on pull_request only, so a stack-repo change that breaks multi-asset passed the e2e gate (which also runs on module-release + workflow_dispatch) without ever running the suite. Mirror e2e.yml's triggers and version-resolution: - add repository_dispatch [module-release] + workflow_dispatch (with contracts_version / provider_version inputs) - a resolve job computes versions exactly like e2e (payload version for the triggering module + latest for the rest on module-release; inputs on workflow_dispatch; latest on PR) and threads them into the reusable - local_dev_ref = PR head ref, else the ref the run is on Triggers + version-wiring only — no suite/compose/e2e.yml changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
multi-asset.ymltriggered onpull_requestonly, so a change in a stack repo (soroban-core / provider-platform / …) that breaks the multi-asset suite passed thee2e.ymlgate — which also runs onrepository_dispatch: [module-release]andworkflow_dispatch— without ever running multi-asset. This closes that hole: multi-asset now runs wherever e2e runs.Change (triggers + version-wiring only —
multi-asset.yml)on:now matchese2e.yml:pull_request+repository_dispatch: [module-release]+workflow_dispatch(withcontracts_version/provider_versioninputs).resolvejob computes versions exactly like e2e — onmodule-release, the payload version for the triggering module (soroban-core→contracts,provider-platform→provider) andlatestfor the rest; onworkflow_dispatch, the inputs; on PR,latest— then threads them intomulti-asset-reusable.ymlviawith:(auses:job can't run steps, hence the separate resolve job).local_dev_ref= PR head ref, else the ref the run is on.No changes to the suite, the Docker composes,
multi-asset-reusable.yml, ore2e.yml.Verification
multi-asset.yml.workflow_dispatch(manual run) and the resolution branch executes — verified on this branch (see PR thread / run link in the handoff).Note (mirrors e2e, surfaced for awareness)
Like
e2e.yml, resolution maps onlysoroban-core→contracts andprovider-platform→provider; acouncil-platformmodule-releaseruns multi-asset againstcouncil:latest(council_version stays default). e2e has no council handling either, so this preserves the "mirror e2e exactly" scope rather than inventing a new mapping.