ci: build frontends with --production in invite-gate and playwright suites - #141
Merged
Conversation
…uites The suites built the consoles and moonlight-pay in dev mode, but deploys ship --production builds. Minification-dependent breakage passed the gate twice: moonlight-pay 0.5.28 and 0.5.29 both rendered a black page in production while the dev-built gate stayed green. Build all three frontends with --production in both suites so the gate exercises the artifact that actually ships. Verified locally: invite gate 6/6 green with production builds across all three frontends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gate suites built all three frontends in dev mode while deploys ship
--productionbuilds. Minification-dependent breakage therefore passed a green gate twice (moonlight-pay 0.5.28 and 0.5.29 black-paged in production; the dev-built gate saw nothing).Switch the six frontend build lines in
docker-compose.invite-gate.ymlanddocker-compose.playwright.ymltodeno task build -- --production— the gate now tests the artifact that ships.Verified locally with
./test.sh invite-gate: 6/6 green with production builds of provider-console, council-console (main), and moonlight-pay (with moonlight-pay#46).Merge order note: merging this first is safe and makes #46's own gate run against its production build.