Skip to content

fix(invite-gate): drop ${{ }} from input description so workflow parses - #86

Merged
AquiGorka merged 3 commits into
mainfrom
fix/invite-gate-reusable-description-no-expression
May 7, 2026
Merged

fix(invite-gate): drop ${{ }} from input description so workflow parses#86
AquiGorka merged 3 commits into
mainfrom
fix/invite-gate-reusable-description-no-expression

Conversation

@AquiGorka

Copy link
Copy Markdown
Contributor

Summary

  • ${{ github.head_ref }} embedded in workflow_call.inputs.local_dev_ref.description is evaluated at workflow-load time, but the github context isn't available there. GitHub rejects the file with Unrecognized named-value: 'github', so the entire reusable workflow is invalid and every caller fails before scheduling a job.
  • Every invite-gate run across moonlight-pay, provider-console, council-console, local-dev's own caller, etc. has failed in 0s with referenced_workflows: [] since 2026-04-22 — invite-gate has never actually run.
  • This PR replaces the embedded expression with prose. Same intent, no expression evaluation.

Test plan

  • CI: this PR's invite-gate run on local-dev should resolve the reusable workflow and actually schedule jobs (no longer 0s failure)
  • After merge: re-run invite-gate on a recent moonlight-pay PR and confirm jobs are scheduled

AquiGorka added 3 commits May 7, 2026 15:14
GitHub evaluates ${{ }} expressions inside workflow_call.inputs.*.description
at workflow-load time, where the github context isn't available. That made
the entire reusable workflow invalid, so every caller (moonlight-pay,
provider-console, council-console, etc.) failed in 0s with "no jobs were run"
since 2026-04-22 — invite-gate has never actually executed.

Replace the embedded expression with prose; description still conveys intent.
The Playwright suite expects ./playwright/freighter-extension/ to be an
unpacked Chromium extension. The directory is gitignored — devs populate
it locally by copying from their Chrome install. CI had nothing there,
so chromium hung trying to --load-extension a missing path and every
test timed out at 180s on browser launch.

Build from source against tag 5.39.0 (matches what's installed locally
right now) and cache the build dir keyed on the tag, so subsequent runs
skip the ~3-5min yarn build. Pinning (rather than "latest") keeps a
Freighter release from silently breaking invite-gate.
Freighter pins "packageManager": "yarn@4.10.0", and `yarn install` errors
out against the runner's global yarn 1.22.22. corepack enable activates
the pinned version. Also switch --frozen-lockfile to --immutable (yarn 4
spelling).
@AquiGorka
AquiGorka merged commit 30cb07d into main May 7, 2026
7 checks passed
@AquiGorka
AquiGorka deleted the fix/invite-gate-reusable-description-no-expression branch May 7, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant