feat(dev): wire councilPlatformUrl into network-dashboard config (PR-B3) - #93
Closed
AquiGorka wants to merge 1 commit into
Closed
feat(dev): wire councilPlatformUrl into network-dashboard config (PR-B3)#93AquiGorka wants to merge 1 commit into
AquiGorka wants to merge 1 commit into
Conversation
Coordinated with council-platform PR-B1 (public events WS) and network-dashboard PR-B2 (activity-feed scaffold). Merge order: A → B1 → B2 → B3. The network-dashboard SPA now talks to council-platform's WS at /api/v1/public/events/ws to render live activity. Without councilPlatformUrl in the generated config, the SPA had no way to discover the local council-platform port, so the WS client falls through to its "offline" branch. One-line addition: surface COUNCIL_PLATFORM_PORT through the generated config.js. Mirrors how rpcUrl is plumbed today. No other changes — parallel-stack overrides via COUNCIL_PLATFORM_PORT continue to work the same way.
Contributor
Author
|
Closing per PM direction — superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Third member of the coordinated PR-B trio. Pairs with:
Merge order: A → B1 → B2 → B3.
What this fixes
infra-up.shgeneratesnetwork-dashboard/public/config.jsfor the local stack. Today the config exposesrpcUrl,horizonUrl,environment,stellarNetwork— but not the council-platform URL. PR-B2's SPA needscouncilPlatformUrlto derive the WS endpoint atws://localhost:${COUNCIL_PLATFORM_PORT}/api/v1/public/events/ws. Without it the SPA logs "councilPlatformUrl not configured" and the feed shows "Offline".This one-liner surfaces
COUNCIL_PLATFORM_PORTthrough the generated config exactly likeSTELLAR_RPC_PORTis surfaced today. Parallel-stack overrides viaCOUNCIL_PLATFORM_PORTcontinue to work — that's why the value is derived from the env var rather than hardcoded.Diff
rpcUrl: "http://localhost:${STELLAR_RPC_PORT}/soroban/rpc", horizonUrl: "http://localhost:${STELLAR_RPC_PORT}", + councilPlatformUrl: "http://localhost:${COUNCIL_PLATFORM_PORT}", };Test plan
./down.sh && ./up.sh, openhttp://localhost:3040, status flips from "Connecting…" to "Live"../setup-c.sh && ./setup-pp.sh, a green✓ PP joinedcard appears in the right rail.