fix(errors): drop dead ReentrantCall/3008 mapping#42
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
soroban-core removed the MOON-06 reentrancy guard (soroban-core#41), including the ReentrantCall = 3008 contract error variant. Remove the now-dead 3008 -> ReentrantCall entry from the SDK error catalog so it stays in sync with the contract. Patch bump 0.11.2 -> 0.11.3.
AquiGorka
force-pushed
the
fix/drop-reentrantcall-error
branch
from
1e0c3ae to
3e53895
Compare
AquiGorka
added a commit
that referenced
this pull request
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the now-dead
3008 -> ReentrantCallentry from the SDK contract-error catalog (src/error/contract-errors.ts).Why
soroban-core removed the MOON-06 reentrancy guard (soroban-core#41) — reentrancy is forbidden by Soroban at the platform level — including dropping the
ReentrantCall = 3_008contract error variant. The SDK's3008 -> ReentrantCallmapping is now dead (maps to a code the contract no longer defines). Removing it keeps the SDK error catalog in sync with the contract.Changes
src/error/contract-errors.ts: remove the3008 / ReentrantCallentry. No other references existed (no imports, re-exports, or tests asserted it).deno.json: patch bump0.11.1 -> 0.11.2.Verification
grep -rn 'ReentrantCall\|3008' src/-> clean (no matches).deno fmt --check,deno lint,deno task test:unitall green locally.Base =
main(where this mapping lives;devuses a different error architecture and never had it).