Drop the redundant remote-only flag - #14
Merged
Merged
Conversation
Remote building is already the default; --local-only is the flag that changes it.
…d now. The test stamped its events from Date.now() but read the buckets with a second, later Date.now(), so a minute boundary crossing mid-test pushed the deposit into the previous bucket and the assertion saw 0.5 instead of 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--remote-onlyrestates the default.flyctl deploy --helpand Fly's docs both state remote building is what happens when neither flag is passed, and--local-onlyis the flag that changes it.Removed from both deploy commands in
deploy-testnet.ymlanddeploy-mainnet.yml. No behaviour change.The same removal already merged in
provider-platformandcouncil-platform, and their deploys ran normally afterwards.Note:
deploy-mainnet.ymltriggers on push to main, so merging fires a mainnet deploy.