chore: route both testnet and mainnet via gh secrets#10
Merged
Conversation
…RL gh secrets Both deploy jobs now read stellarNetwork and rpcUrl from gh secrets (STELLAR_NETWORK/RPC_URL on testnet; MAINNET_STELLAR_NETWORK/ MAINNET_RPC_URL on mainnet). Removes the gateway.fm hardcoding from the mainnet job and the soroban-testnet hardcoding from the testnet job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repo gh secrets set in the same change:
Note for PM thread
Phase 0 finding #3 said network-dashboard derives Stellar config at runtime from council-platform and makes no direct RPC calls. Verified during D4: dashboard DOES make direct RPC calls — src/lib/stellar.ts:139 (new s.rpc.Server(RPC_URL)) is used by getChannelSupply and other contract reads. ClickUp 86c9n8cby (proxy refactor) scope should be extended to include network-dashboard.
The Quasar token IS embedded in the dashboard's mainnet public/config.js as the accepted exposure for the silent release.
Part of the silent mainnet flip (ClickUp 86c9c86b6).
Test plan