chore: apply deno fmt, fix lint, add CI fmt/lint gates#7
Merged
Conversation
- run deno fmt across the repo (23 files) - deno lint --fix for no-window/no-window-prefix (8 fixes) - inline deno-lint-ignore on 2 build.ts pinned-version imports - inline deno-lint-ignore require-await on 3 view fns whose return type satisfies the router's Promise<HTMLElement> contract - add fmt and lint jobs to ci.yml - bump version 0.2.3 -> 0.2.4 No behavior changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the mainnet-hygiene effort. Brings the repo to a clean state under
deno fmt --checkanddeno lint, and adds CI gates so regressions are caught at PR time.Changes
deno fmtacross the repo (23 files reformatted)deno lint --fixhandled 8no-window/no-window-prefix(window -> globalThis)// deno-lint-ignore no-import-prefixon 2 build.ts imports that intentionally pin URL/version// deno-lint-ignore require-awaiton 3 view functions whose declared return type satisfies the router'sPromise<HTMLElement>contractfmtandlintjobs to ci.ymlNo behavior changes.
Test plan
deno fmt --checkcleandeno lintclean (was 13 errors)deno task test— 28/28 passdeno task buildsucceeds