chore(fly): drop iac-shadow STELLAR_RPC_URL from fly.testnet.toml - #39
Merged
Conversation
iac/destinations.yaml is the source of truth for this secret; the [env] entry was a duplicate that silently rotted whenever iac rotated the value. Current value matches iac, so this is a no-runtime-change cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes the
STELLAR_RPC_URLline fromfly.testnet.toml [env]that duplicated an iac-owned secret name.iac/destinations.yamlis the source of truth for this secret on the testnet Fly app.[env]entry was silently shadowed by the Fly secret iac sets; it would have rotted if iac ever rotated the value.[env]value matches what iac sets, so this is a no-runtime-change cleanup — iac/destinations.yaml remains the sole source of truth.Changes
fly.testnet.toml: drop 1 line inside[env]—STELLAR_RPC_URL.deno.json: 0.5.20 → 0.5.21 (independent final commit).Test plan
deno fmt --checkcleandeno lintcleandeno task test:unit— 27 passed, 0 faileddeno task test:integration— 25 passed, 0 failedpython3 tomllibparsesfly.testnet.tomlcleanlygit grep -nFfor the deleted line returns 0 hits on the branch