refactor(http): drop deprecation-stub routes from the migrated dashboard / entities / events surface - #112
Merged
Merged
Conversation
…ard / entities / events surface PR #106 migrated every dashboard/entities/events route to the per-PP /api/v1/providers/:ppPublicKey/... shape and left 410 Gone stubs at the old un-scoped paths so callers could migrate. The migration is settled and no caller in any of the consumer repos still hits the un-scoped paths, so drop the stubs and let the router answer 404 for those URLs. Removes 14 stubs in dashboard/routes.ts plus the single-stub entities/ and events/ routers (and their mount in v1.routes.ts), the local gone() helper, the deprecation comment block, and the three integration tests that asserted the 410 behavior of these specific stubs. The live per-PP handlers (dashboard/*.ts, entities/post.ts, entities/challenge.ts, events/ws-handler.ts) are unchanged and stay mounted through providers/routes.ts. Follow-up to #106.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #106.
Summary
PR #106 migrated every dashboard / entities / events route to the per-PP
/api/v1/providers/:ppPublicKey/...shape and left 410 Gone stubs at the old un-scoped paths so callers could migrate. The migration is settled and no caller in any consumer repo still hits the un-scoped paths, so the stubs are dropped — the router now answers 404 (route not found) for those URLs.What changes
src/http/v1/dashboard/routes.ts(POST /dashboard/pp/delete,GET /dashboard/{channels,mempool,operations,treasury,utxos,transactions,transactions/:id,bundles/:id,audit-export,metrics,council/membership},POST /dashboard/council/{join,membership})POST /entities(un-scoped) — the entiresrc/http/v1/entities/routes.tsbecomes empty and is deletedGET /events/ws(un-scoped) — the entiresrc/http/v1/events/routes.tsbecomes empty and is deletedbuildEntitiesRouter+buildEventsRouterimports and mounts fromsrc/http/v1/v1.routes.ts.src/http/v1/dashboard/routes.ts.bundle-admin.test.ts,dashboard-metrics.test.ts,events-ws.test.ts).0.7.3.The live per-PP handlers (
dashboard/*.ts,entities/post.ts,entities/challenge.ts,events/ws-handler.ts) are unchanged and stay mounted viaproviders/routes.ts.Test plan
deno fmt --checkcleandeno lintcleandeno task test:unit— 64 passed / 0 faileddeno task test:integration— 96 passed / 0 failed (99 → 96 is the 3 deleted 410-stub tests, no regressions)channels,metrics,treasury,entities) — all respond live (401 fromjwtMiddlewareon the protected ones; the publicentitiesPOST hitsrequirePpExistsand answersProvider not found)provider-console,council-console,network-dashboard,network-dashboard-platform,moonlight-pay,browser-wallet,moonlight-sdk,local-dev) — zero non-test call sites on any of the 16 deleted paths