chore(fly): drop iac-shadow OTEL_* lines from fly.testnet.toml - #114
Merged
Conversation
iac/destinations.yaml is the source of truth for OTEL_DENO, OTEL_SERVICE_NAME, and OTEL_EXPORTER_OTLP_PROTOCOL on this app; the [env] duplicates were silently shadowed by the Fly secrets and would have rotted if iac rotated them. Current values match iac, so this is a no-runtime-change cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes the 3
OTEL_*lines fromfly.testnet.toml [env]that duplicated iac-owned secret names.iac/destinations.yamlis the source of truth forOTEL_DENO,OTEL_SERVICE_NAME, andOTEL_EXPORTER_OTLP_PROTOCOLon this testnet Fly app.[env]entries were silently shadowed by the Fly secrets iac sets; they would have rotted if iac ever rotated the values.[env]values match what iac sets, so this is a no-runtime-change cleanup — iac/destinations.yaml remains the sole source of truth.Changes
fly.testnet.toml: drop 3 lines inside[env]—OTEL_DENO,OTEL_SERVICE_NAME,OTEL_EXPORTER_OTLP_PROTOCOL.deno.json: 0.7.4 → 0.7.5 (independent final commit; rebased onto post-chore: remove PAY_DEMO_ENABLED + pay/demo surface entirely #113 main).Test plan
deno fmt --checkcleandeno lintcleandeno task test:unit— 64 passed, 0 faileddeno task test:integration— 96 passed, 0 faileddeno task test:pay— 116 passed, 0 failedpython3 tomllibparsesfly.testnet.tomlcleanlygit grep -nFfor each deleted line returns 0 hits on the branch