feat(dashboard): expose bundle failureDetail on operator bundle endpoints#132
Merged
Conversation
Add the structured on-chain failure reason (failureDetail { code, source,
message, name }) — already recorded on the bundle and returned on the
entity endpoint — to the operator-facing dashboard bundle responses: the
detail handler (GET /providers/:pp/bundles/:id) and each list item (GET
/providers/:pp/bundles). It's the operator's own bundles, so there's no
privacy reason to withhold why a bundle failed on-chain. Lets
provider-console surface the reason to the operator (ClickUp 86cahd1d4).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClickUp 86cahd1d4 — anchor for the provider-console structured-errors follow-up (provider-console#40 consumes this).
What
The structured on-chain failure reason
failureDetail { code, source, message, name }is already recorded on every FAILED bundle and returned on the entity endpoint (get.ts), but the operator-facing dashboard bundle endpoints omitted it — so provider-console could show that a bundle failed but never why.This adds
failureDetailto:GET /api/v1/providers/:ppPublicKey/bundles/:id— detail responsedata.failureDetail(null unless FAILED).GET /api/v1/providers/:ppPublicKey/bundles— each list item'sfailureDetail(added to the select + the mapped item).Operator's own bundles (JWT + ownership check already applied), so there's no privacy reason to withhold the reason.
Notes
Pure passthrough of an existing column (
operations_bundle.failure_detail) — no new imports, no logic change.deno check(2.8.2) green. Existingbundle-admin.test.tsis routing-only and unaffected.deno.json 0.9.8 → 0.9.9.