fix(agent-core): preserve Bash stdout after process exit - #2541
Open
barkure wants to merge 3 commits into
Open
Conversation
Local process wait() resolved on the child exit event even though stdout and stderr could still be open. Resolve on close so callers capture buffered tail output, and cover the ordering with a deterministic process lifecycle test.
🦋 Changeset detectedLatest commit: 72514bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
barkure
marked this pull request as ready for review
August 2, 2026 14:44
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94f6ea73bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #2426
Problem
ProcessBackgroundTaskstarts consuming stdout and stderr before waiting for the process, but after the process exited it allowed only 250 ms for those streams to end. If stream closure was delayed beyond that grace period, the task disposed the streams and returned a successful Bash result without the late output.Making
KaosProcess.wait()wait for stream closure globally is unsafe: callers are allowed to wait before reading, andBufferedReadableapplies backpressure once its 128 KiB prefetch buffer fills. In that usage, waiting forclosecan deadlock because the paused stream needs a reader before it can close.What changed
KaosProcess.wait()tied to direct process exit so wait-before-read remains safe.ProcessBackgroundTask, which actively consumes both output streams from startup, wait until those streams end before completing and disposing the process.No user documentation update is needed because this restores existing Bash output behavior without adding or changing user-facing configuration.
Verification
@moonshot-ai/kimi-codepatchgit diff --checkThe original WSL2 environment was not available for a manual reproduction. The regression tests cover the stream-drain race and the wait-before-read backpressure boundary independently.
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.