fix(agent-core): tolerate unreadable .git probes on UNC workspaces - #2546
Open
djfch wants to merge 1 commit into
Open
fix(agent-core): tolerate unreadable .git probes on UNC workspaces#2546djfch wants to merge 1 commit into
djfch wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 7e912cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #2540
Problem
See linked issue. On Windows, workspaces opened via a UNC path (network share, e.g. a NAS) that are not git repositories cannot send any chat message: the project-root walk stats
\\server\.gitpast the share root, Node/libuv reportsUNKNOWNinstead ofENOENT, and the probe helper rethrew it, failing the whole chat preflight.What changed
.gitmarker probe in the MCP config loader's project-root walk now treats anystatfailure as "not found" instead of rethrowing non-ENOENT/ENOTDIRerrors — a probe for an optional marker file should never throw. This matches the existing probe helpers elsewhere in the repo (e.g. workspace-local config, profile context) and also coversEPERM-style failures, not justUNKNOWN.UNKNOWNandEPERMprobe failures and assert the walk falls back to the starting directory (platform-independent via a partialnode:fs/promisesmock).The sibling probe copies in the agent-file root resolvers (both engines) were left untouched: their callers already catch and downgrade probe errors to warnings, so they never had this crash.
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.