fix(web): keep long mermaid labels inside their nodes - #2578
Open
djfch wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 74e0715 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0deecb0ffb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #2577
Problem
See linked issue.
What changed
Long mermaid labels overflowed their node boxes in the web UI: mermaid wraps long labels with CSS soft wrap inside
<foreignObject>and sizes the node rect from the wrapped measurement, but the SVG sanitizer (stream-markdown-parser, pulled in by markstream-vue) flattens every<foreignObject>into a single-line<text>, keeping only literal<br>breaks. The full-width single-line label then renders centered on a rect sized for the wrapped width, overflowing both sides and overlapping neighbors.This PR preprocesses chat markdown before rendering: every
```mermaidfence gets an injected%%{init: {"htmlLabels": false}}%%directive (behind a leading%%comment line so markstream still prepends its theme directive, which it only does when the code does not already start with a directive). With htmlLabels off, mermaid lays out native SVG text with real width-based line breaking (tspans), so the sanitizer has no<foreignObject>left to flatten and measurement and rendering agree.Notes:
htmlLabelskey —flowchart.htmlLabelsis deprecated and silently shadowed by the global default in mermaid 11.15 (verified empirically; the scoped key changes nothing).~~~fences, streaming partial input, diagrams carrying their own init directive, and the invariant that injected code never starts with%%{(which would disable markstream's theme prepend).Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.