Skip to content

fix(tui): sanitize foreground Bash tool output #2919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nhatduy227 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

fix(tui): sanitize foreground Bash tool output #2919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sanitize-foreground-bash-output.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@moonshot-ai/kimi-code": patch
---

Sanitize foreground Bash tool output so captured terminal escape sequences no longer change the host terminal state.
5 changes: 4 additions & 1 deletion apps/kimi-code/src/tui/components/messages/shell-execution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { Container, Text } from '@moonshot-ai/pi-tui';

import { currentTheme } from '#/tui/theme';
import type { ToolCallBlockData, ToolResultBlockData } from '#/tui/types';
import { sanitizeShellOutput } from '#/tui/utils/shell-output';

import type { ResultRenderer } from './tool-renderers/types';
import { PREVIEW_LINES } from './tool-renderers/types';
Expand Down Expand Up @@ -68,8 +69,10 @@ export class ShellExecutionComponent extends Container {
expandHint: boolean,
): void {
if (!result.output) return;
// Untrusted bytes: sanitize the whole buffer, not each chunk, so escape
// sequences split across live-output chunks cannot reach the terminal.
this.addChild(
new TruncatedOutputComponent(result.output, {
new TruncatedOutputComponent(sanitizeShellOutput(result.output), {
expanded,
isError: result.is_error ?? false,
maxLines: previewLines,
Expand Down