Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise a Barley::InvalidAttributeError on type errors #9

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

MoskitoHero
Copy link
Owner

@MoskitoHero MoskitoHero commented Jun 16, 2024

Description

Up to now, type errors raised by dry-types within a Barley serializer were not very clear and not easy to track.

This MR introduces a new Barley::InvalidAttributeError to handle type errors in attributes with the key name, the expected type and the actual type found.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • serializer_test.rb

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@MoskitoHero MoskitoHero self-assigned this Jun 16, 2024
@MoskitoHero MoskitoHero merged commit ff80698 into main Jun 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant