Repository navigation
fix(trades): clarify the waiting-for-deposit text #932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -3868,9 +3868,11 @@ | |||||
| "tradeVerbPayBond": "Pay deposit", | ||||||
| "@tradeVerbPayBond": {"description": "Trade list verb / trade detail primary action: pay the anti-abuse deposit that parks the take"}, | ||||||
| "tradeHeadlineWaitingBond": "Lock your deposit to continue", | ||||||
| "@tradeHeadlineWaitingBond": {"description": "Trade detail headline while the taker's anti-abuse deposit is unpaid"}, | ||||||
| "tradeInstructionWaitingBond": "The node holds this take until the refundable deposit is paid. The order stays open to others meanwhile.", | ||||||
| "@tradeInstructionWaitingBond": {"description": "Trade detail body while the taker's anti-abuse deposit is unpaid"}, | ||||||
| "@tradeHeadlineWaitingBond": {"description": "Trade detail headline while the user's anti-abuse deposit is unpaid, taker's or maker's"}, | ||||||
| "tradeInstructionWaitingBond": "Pay the deposit to secure this order. Until then it stays open, and whoever pays their deposit first gets it. The deposit is locked, not spent: it is released when the trade ends or is canceled, and you can only lose it if you miss a step's deadline or lose a dispute.", | ||||||
| "@tradeInstructionWaitingBond": {"description": "Trade detail body while the taker's anti-abuse deposit is unpaid: the order stays takeable and the first deposit to lock wins; what locks and releases the deposit"}, | ||||||
| "tradeInstructionWaitingMakerBond": "Pay the deposit to publish your order. Until then nobody can see it. The deposit is locked, not spent: it is released when the order ends or is canceled, and you can only lose it if you miss a step's deadline or lose a dispute.", | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do not limit dispute forfeiture to the losing party. The spec allows a solver to slash either party or both, independently of the trade outcome. The maker instruction says the deposit can be lost "only" by missing a step's deadline or losing a dispute. That is inaccurate. A user who wins a dispute can still be slashed. Remove the "only" limit and state that a dispute can cost the deposit regardless of the trade outcome. Apply the same correction to the taker instruction and to the de, fr, it, nl, and pt translations. Suggested fix for app_en.arb (maker instruction)
Committable suggestion
|
||||||
| "@tradeInstructionWaitingMakerBond": {"description": "Trade detail body while the maker's anti-abuse deposit is unpaid: the order is not published until it locks; what locks and releases the deposit"}, | ||||||
| "takeOrderBondNotice": "This node asks takers to lock a refundable deposit first; it comes back when the trade ends honestly.", | ||||||
| "@takeOrderBondNotice": {"description": "Take screen note on a bond-enabled node when no estimate is available"}, | ||||||
| "takeOrderBondNoticeEstimate": "This node asks takers to lock a refundable deposit of ≈ {sats} sats first; it comes back when the trade ends honestly.", | ||||||
|
|
||||||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.