Update LRU Cache package (dotansimha#2801)

* Update LRU Cache * chore(dependencies): updated changesets for modified dependencies --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Moustafaa91 · May 26, 2023 · 6f83c0c · 6f83c0c
1 parent 7bb2703
commit 6f83c0c
Show file tree

Hide file tree

Showing 10 changed files with 35 additions and 32 deletions.
diff --git a/.changeset/@graphql-yoga_plugin-apq-2801-dependencies.md b/.changeset/@graphql-yoga_plugin-apq-2801-dependencies.md
@@ -0,0 +1,5 @@
+---
+'@graphql-yoga/plugin-apq': patch
+---
+dependencies updates:
+  - Removed dependency [`lru-cache@^7.14.1` ↗︎](https://www.npmjs.com/package/lru-cache/v/7.14.1) (from `dependencies`)
diff --git a/.changeset/graphql-yoga-2801-dependencies.md b/.changeset/graphql-yoga-2801-dependencies.md
@@ -0,0 +1,5 @@
+---
+'graphql-yoga': patch
+---
+dependencies updates:
+  - Updated dependency [`lru-cache@^9.0.0` ↗︎](https://www.npmjs.com/package/lru-cache/v/9.0.0) (from `^7.14.1`, in `dependencies`)
diff --git a/import-map.json b/import-map.json
@@ -15,6 +15,6 @@
     "@whatwg-node/events": "npm:@whatwg-node/[email protected]",
     "@whatwg-node/server": "npm:@whatwg-node/server",
     "@repeaterjs/repeater": "npm:@repeaterjs/repeater",
-    "lru-cache": "npm:lru-cache@^7.14.1"
+    "lru-cache": "npm:lru-cache@^9.0.0"
   }
 }
diff --git a/packages/graphql-yoga/package.json b/packages/graphql-yoga/package.json
@@ -61,7 +61,7 @@
     "@whatwg-node/fetch": "^0.9.0",
     "@whatwg-node/server": "^0.8.0",
     "dset": "^3.1.1",
-    "lru-cache": "^7.14.1",
+    "lru-cache": "^9.0.0",
     "tslib": "^2.5.2"
   },
   "devDependencies": {

diff --git a/packages/graphql-yoga/src/index.ts b/packages/graphql-yoga/src/index.ts
@@ -10,6 +10,7 @@ export * from './server.js'
 export * from './subscription.js'
 export * from './types.js'
 export { maskError } from './utils/mask-error.js'
+export { createLRUCache } from './utils/create-lru-cache.js'
 export type {
   // Handy type utils
   Maybe,

diff --git a/packages/graphql-yoga/src/utils/create-lru-cache.ts b/packages/graphql-yoga/src/utils/create-lru-cache.ts
@@ -1,8 +1,18 @@
-import LRU from 'lru-cache'
+/* eslint-disable @typescript-eslint/ban-types */
+import { LRUCache as LRU } from 'lru-cache'
 
 const DEFAULT_MAX = 1024
 const DEFAULT_TTL = 3_600_000
 
-export function createLRUCache<T>() {
-  return new LRU<string, T>({ max: DEFAULT_MAX, ttl: DEFAULT_TTL })
+export type LRUCache<T extends {}> = LRU<string, T>
+export interface LRUCacheOptions {
+  max?: number
+  ttl?: number
+}
+
+export function createLRUCache<T extends {}>({
+  max = DEFAULT_MAX,
+  ttl = DEFAULT_TTL,
+}: LRUCacheOptions = {}) {
+  return new LRU<string, T>({ max, ttl })
 }
diff --git a/packages/plugins/apq/package.json b/packages/plugins/apq/package.json
@@ -42,9 +42,6 @@
     "directory": "dist",
     "access": "public"
   },
-  "dependencies": {
-    "lru-cache": "^7.14.1"
-  },
   "devDependencies": {
     "graphql-yoga": "3.9.1"
   },

diff --git a/packages/plugins/apq/src/index.ts b/packages/plugins/apq/src/index.ts
@@ -1,5 +1,9 @@
-import { createGraphQLError, Plugin, PromiseOrValue } from 'graphql-yoga'
-import LRU from 'lru-cache'
+import {
+  createGraphQLError,
+  Plugin,
+  PromiseOrValue,
+  createLRUCache,
+} from 'graphql-yoga'
 
 export async function hashSHA256(
   str: string,
@@ -27,7 +31,7 @@ export interface APQStoreOptions {
 export function createInMemoryAPQStore(
   options: APQStoreOptions = {},
 ): APQStore {
-  return new LRU({
+  return createLRUCache<string>({
     max: options.max ?? 1000,
     ttl: options.ttl ?? 36_000,
   })

diff --git a/packages/plugins/persisted-operations/package.json b/packages/plugins/persisted-operations/package.json
@@ -48,7 +48,6 @@
     "graphql-yoga": "^3.9.1"
   },
   "devDependencies": {
-    "@types/lru-cache": "7.10.9",
     "graphql-yoga": "^3.9.1"
   },
   "type": "module"

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml