Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Czech translation #235

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Update Czech translation #235

merged 1 commit into from
Jan 19, 2024

Conversation

nijel
Copy link
Contributor

@nijel nijel commented Jan 4, 2024

Completed and improved Czech translation.

Completed and improved Czech translation.
@github-actions github-actions bot added the translation This PR modify translation files label Jan 4, 2024
@nijel
Copy link
Contributor Author

nijel commented Jan 4, 2024

The translation is still a bit clumsy because of the following logic:

const e = localize(event.translationKey);
return [
localize(level.translationKey + '.event').replace(
'{event}',
localize(event.translationKey),
),
e.charAt(0).toUpperCase() + e.slice(1),
];

It uses the same event name as a standalone text and as a part of a sentence. Having them separated could result in a much nicer translation.

  • Before this PR it is: Povodeň / Žluté povodeň varování
  • This PR workarounds lack of declination as: Povodeň / Žluté varování: povodeň
  • Even better would be: Povodeň / Žluté varování před povodní

@MrBartusek
Copy link
Owner

@martin131 Can you take a look at that?

@MrBartusek
Copy link
Owner

The translation is still a bit clumsy because of the following logic:

const e = localize(event.translationKey);
return [
localize(level.translationKey + '.event').replace(
'{event}',
localize(event.translationKey),
),
e.charAt(0).toUpperCase() + e.slice(1),
];

It uses the same event name as a standalone text and as a part of a sentence. Having them separated could result in a much nicer translation.

  • Before this PR it is: Povodeň / Žluté povodeň varování
  • This PR workarounds lack of declination as: Povodeň / Žluté varování: povodeň
  • Even better would be: Povodeň / Žluté varování před povodní

Quite honestly, I do not speak Czech and I've no idea how to proceed here. I think we can leave this as is for the time being unless anybody would want to provide PR for that.

@nijel
Copy link
Contributor Author

nijel commented Jan 4, 2024

I think what this PR is good enough, it's just a note that the code could be improved to better support localization.

@MrBartusek MrBartusek changed the title Update cs.json Update Czech translation Jan 19, 2024
@MrBartusek MrBartusek merged commit 0fac497 into MrBartusek:master Jan 19, 2024
6 checks passed
@MrBartusek
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation This PR modify translation files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants