-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
weatheralerts: Add alert types #277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this looks good cold weather was added and Extreme Heat from the NWS
Nick do we have to wait for MrBartusek to approve this before it is merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Thank you for this PR.
This will indeed fix most of the issues reported in #276. You can also add a Hydrologic Outlook
warning - as per #276 (comment)
The other issue is that the mentioned issue is specifically reported for the https://github.com/ddeatrich/weatheralerts integration, which is different from the one that we directly support: https://github.com/custom-components/weatheralerts. However, it seems like this one is not maintained anymore. Can you please tell me if this is a fork and whether these integrations have the same attributes?
I use the custom components weatheralerts which I think most people use. I could not get the ddeatrich/weatheralerts to work with the meteoalarm Card. The ddeatrich is a fork. Hope all is well. Brandon
…________________________________
From: Bartosz Dokurno ***@***.***>
Sent: Thursday, February 13, 2025 6:39 AM
To: MrBartusek/MeteoalarmCard ***@***.***>
Cc: cleevo989 ***@***.***>; Comment ***@***.***>
Subject: Re: [MrBartusek/MeteoalarmCard] weatheralerts: Add alert types=0D (PR #277)
@MrBartusek requested changes on this pull request.
Hey! Thank you for this PR.
This will indeed fix most of the issues reported in #276<#276>. You can also add a Hydrologic Outlook warning - as per #276 (comment)<#276 (comment)>
The other issue is that the mentioned issue is specifically reported for the https://github.com/ddeatrich/weatheralerts integration, which is different from the one that we directly support: https://github.com/custom-components/weatheralerts. However, it seems like this one is not maintained anymore. Can you please tell me if this is a fork and whether these integrations have the same attributes?
—
Reply to this email directly, view it on GitHub<#277 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A7YVXE4KZY7ONGBIT6FSN5T2PSAA3AVCNFSM6AAAAABVPEPTSWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMJUG4ZDCNRWGU>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Needed for "Hydrologic Outlook" event
Sorry I did not even notice the original issue mentioned ddeatrich/weatheralerts. But the other comments went on about missing alert type/level, and these changes will fix that. |
I'll admit I probably didn't describe my issue properly, but my integration was and is working without issue, it was just certain alert types were not showing up in the card like others. The Cold Weather Alert had cleared in my area so I couldn't reproduce the error, so my screenshot was not accurate. I think the merged fix will resolve my issue as well, just wanted to offer some clarity. Thanks for all your help and insight, the card has been super helpful with the awful weather we've had in the northeast US these past couple weeks. |
No description provided.