Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weatheralerts: Add alert types #277

Merged
merged 2 commits into from
Feb 16, 2025
Merged

Conversation

nicksmith53
Copy link
Contributor

@nicksmith53 nicksmith53 commented Jan 19, 2025

No description provided.

Copy link

@cleevo989 cleevo989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this looks good cold weather was added and Extreme Heat from the NWS

@cleevo989
Copy link

Nick do we have to wait for MrBartusek to approve this before it is merged?

Copy link
Owner

@MrBartusek MrBartusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thank you for this PR.

This will indeed fix most of the issues reported in #276. You can also add a Hydrologic Outlook warning - as per #276 (comment)

The other issue is that the mentioned issue is specifically reported for the https://github.com/ddeatrich/weatheralerts integration, which is different from the one that we directly support: https://github.com/custom-components/weatheralerts. However, it seems like this one is not maintained anymore. Can you please tell me if this is a fork and whether these integrations have the same attributes?

@cleevo989
Copy link

cleevo989 commented Feb 13, 2025 via email

Needed for "Hydrologic Outlook" event
@nicksmith53
Copy link
Contributor Author

Sorry I did not even notice the original issue mentioned ddeatrich/weatheralerts.
So Bestivus seems to be having his own issue with an unsupported integration.

But the other comments went on about missing alert type/level, and these changes will fix that.
I'm also using custom-components/weatheralerts.

@MrBartusek MrBartusek merged commit e3a9583 into MrBartusek:master Feb 16, 2025
6 checks passed
@nicksmith53 nicksmith53 deleted the patch-1 branch February 16, 2025 23:46
@Bestivus
Copy link

Sorry I did not even notice the original issue mentioned ddeatrich/weatheralerts. So Bestivus seems to be having his own issue with an unsupported integration.

But the other comments went on about missing alert type/level, and these changes will fix that. I'm also using custom-components/weatheralerts.

I'll admit I probably didn't describe my issue properly, but my integration was and is working without issue, it was just certain alert types were not showing up in the card like others. The Cold Weather Alert had cleared in my area so I couldn't reproduce the error, so my screenshot was not accurate.

I think the merged fix will resolve my issue as well, just wanted to offer some clarity. Thanks for all your help and insight, the card has been super helpful with the awful weather we've had in the northeast US these past couple weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants