Fix command injection vulnerability in CLI preparation scripts #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical command injection vulnerability in three CLI preparation scripts that use
execSync()with template literals containing user-controllable paths.Vulnerability Details
The vulnerable code pattern was present in:
src/cli/prepare-phantom.mjssrc/cli/prepare-coinbase.mjssrc/cli/prepare-metamask.mjsBefore (vulnerable):
This pattern is vulnerable to command injection because if
scriptPathcontains shell metacharacters (like; rm -rf /), they would be executed as part of the shell command.Fix Implementation
After (secure):
Why This Fix Works
spawnSync()with array form treats each argument as a literal string, preventing shell interpretationSecurity Impact
This change eliminates the possibility of command injection attacks while preserving all existing functionality. The CLI scripts will continue to work exactly as before, but are now secure against malicious input in file paths.
Fixes #29.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.