Title: feat: add lint, typecheck, and unit test steps to frontend CI#42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Body:
Summary
Closes #13
Added npm run typecheck (tsc --noEmit) and npm run test (Vitest) steps to .github/workflows/frontend-ci.yml, running between lint and build
Added "typecheck" and "test" scripts to package.json; installed vitest as a dev dependency
Created vitest.config.ts with path alias support (@/)
Added src/tests/smoke.test.ts — a passing smoke test that proves the CI test step runs
Documented required CI checks in README.md with a status badge and local fix instructions
Test plan
npm run lint passes with no errors
npm run typecheck passes with no type errors
npm run test passes (1 smoke test)
npm run build passes
Introducing an ESLint error in a PR causes CI to fail on the Lint step
Introducing a TypeScript type error causes CI to fail on the Type check step