Open
Conversation
The fastest is STL sort() :) The next is "quicksort". And the slowest is "bubble sort", though I like it for it's simplicity :)
| public: | ||
| Array() //конструктор без параметров | ||
| { | ||
| size = 1; |
Owner
There was a problem hiding this comment.
зачем size в один элемент?
| Array() //конструктор без параметров | ||
| { | ||
| size = 1; | ||
| arr = new int[size]; |
Owner
There was a problem hiding this comment.
Suggested change
| arr = new int[size]; | |
| arr = new int[size]{}; |
вам не нужно будет писать ниже цикл
| Array(int s) //конструктор с одним параметром | ||
| { | ||
| size = s; | ||
| arr = new int[size]; |
Owner
There was a problem hiding this comment.
это вынесите в список инициализации
| Array(const Array &source) //конструктор копирования | ||
| { | ||
| size = source.size; | ||
| arr = new int[size]; |
Owner
There was a problem hiding this comment.
эти две строки вынесите в список инициализации
|
|
||
| void set() //ввод случайных элементов массива | ||
| { | ||
| srand(time(0)); |
Owner
There was a problem hiding this comment.
лучше nullptr вместо 0, time просто принимает указатель
|
|
||
| void sort() //сортировка массива по возрастанию | ||
| { | ||
| int temp; |
Owner
There was a problem hiding this comment.
думаю что лучше эту переменную внести внутри цикла
| } | ||
| } | ||
| int max() { | ||
| sort(); |
Owner
There was a problem hiding this comment.
не думаю что соритировка это хорошая идея для получения максимального элемента, т.е. я вызываю метод max а по итогу мы сортируем массив
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.