Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Qt3 code from libmythupnp #1056

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
2d2c541
create BlockingTcpSocket
ulmus-scott Feb 26, 2025
559b3e5
remove set but unused UPnpSearchTask::m_addressList
ulmus-scott Mar 2, 2025
00a5f81
libmythupnp/upnptasksearch.*: only include used headers
ulmus-scott Mar 2, 2025
2bed209
UPnpSearchTask::ProcessDevice(): use const UPnpDevice&
ulmus-scott Mar 2, 2025
3597758
UPnpSearchTask::UPnpSearchTask(): copy and std::move()
ulmus-scott Mar 2, 2025
3a2636b
libmythupnp/upnptasksearch.*: remove unnecessary blank lines and comm…
ulmus-scott Mar 2, 2025
e9a83c4
libmythupnp/upnptasksearch.cpp: remove unused static variable
ulmus-scott Mar 2, 2025
6c1022c
UPnpSearchTask::SendMsg(): re-enable log message
ulmus-scott Mar 2, 2025
81c4e2a
UPnpSearchTask::SendMsg(): remove QString temporary variables
ulmus-scott Mar 2, 2025
531e455
UPnpSearchTask: replace Qt3 MSocketDevice with QUpdSocket
ulmus-scott Mar 3, 2025
4574e01
libmythupnp/upnptasksearch.*: only include used headers
ulmus-scott Mar 3, 2025
ef592fc
libmythupnp/ssdp.h: only include used headers
ulmus-scott Mar 3, 2025
a11ac7c
UPnpNotifyTask::SendNotifyMsg(): remove QMutexLocker
ulmus-scott Mar 3, 2025
81804d1
libmythupnp/upnptasknotify.*: remove unnecessary blank lines and comm…
ulmus-scott Mar 3, 2025
94016d2
UPnpNotifyTask::ProcessDevice(): use const UPnpDevice&
ulmus-scott Mar 3, 2025
77a6a92
UPnpNotifyTask::SendNotifyMsg(): remove QString temporary variables
ulmus-scott Mar 3, 2025
bd521c6
UPnpNotifyTask: replace Qt3 MMulticastSocketDevice with QUpdSocket
ulmus-scott Mar 3, 2025
9efa9f2
UPnpNotifyTask: use member initializer list
ulmus-scott Mar 3, 2025
320e14b
remove MBroadcastSocketDevice
ulmus-scott Mar 3, 2025
b1fd5a8
make SSDP::m_sockets[SocketIdx_Search] local to SSDP::PerformSearch()
ulmus-scott Mar 3, 2025
a02a860
SSDP::PerformSearch(): replace Qt3 MMulticastSocketDevice with QUpdSo…
ulmus-scott Mar 3, 2025
abce551
libmythupnp/ssdp.h: remove include of ssdpcache.h
ulmus-scott Mar 3, 2025
b6c4959
move SSDPExtension to its own file
ulmus-scott Mar 3, 2025
ae789d2
SSDP: replace Qt3 MMulticastSocketDevice with QUpdSocket
ulmus-scott Mar 3, 2025
df4bfc2
remove now unused Qt3 MSocketDevice
ulmus-scott Mar 4, 2025
ee2228c
SSDP: remove unused m_lock and set but unused m_bAnnouncementsEnabled
ulmus-scott Mar 4, 2025
4c48462
fix ssdp:discover response receipt
ulmus-scott Mar 7, 2025
3428b33
PortChecker::checkPort(): reduce blocking time
ulmus-scott Mar 7, 2025
4d47999
PortChecker::checkPort(): fix indent
ulmus-scott Mar 7, 2025
eaf6ac2
SSDP::PerformSearch(): reuse the QUdpSocket from SSDPReceiver
ulmus-scott Mar 7, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
UPnpNotifyTask::SendNotifyMsg(): remove QMutexLocker
This has not locked for the address list since 2008 with
0a3cbf5.

The only change is that UPnpNotifyTask::m_eNTS may now change, which is only
read to determine if the datagram should be sent twice.
ulmus-scott committed Mar 4, 2025
commit a11ac7c1be4b098bdb82962c6f61e746b9bc8712
2 changes: 0 additions & 2 deletions mythtv/libs/libmythupnp/upnptasknotify.cpp
Original file line number Diff line number Diff line change
@@ -81,8 +81,6 @@ void UPnpNotifyTask::SendNotifyMsg( MSocketDevice *pSocket,
.arg(pSocket->address().toString(), QString::number(pSocket->port()),
sNT, sUSN));

QMutexLocker qml(&m_mutex); // for addressList

// -------------------------------------------------------------------
// Refresh IP Address List in case of changes
// -------------------------------------------------------------------